Maniphest T63312

protect.py should have different messages for protect/unprotect pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 13 2014, 1:46 PM

Tags

Referenced Files

None

Subscribers

pywikibot-bugs-list

Description

Now we have the same edit summary for both operations, in core and compat

Version: core-(2.0)
Severity: minor

Details

Reference: bz61312

	Subject	Repo	Branch	Lines +/-
	Use unprotect i18n messages	pywikibot/core	master	+17 -10
	Add unprotection messages	pywikibot/i18n	master	+45 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Sn1per	T87155 Unit tests for protect.py
		Resolved		Sn1per	T63312 protect.py should have different messages for protect/unprotect pages
		Resolved		Sn1per	T87124 protect.py only unprotects pages because it cannot properly determine which protection types are valid

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:07 AM

• bzimport added projects: Pywikibot-Scripts, TestMe.

• bzimport set Reference to bz61312.

• bzimport added a subscriber: Unknown Object (????).

Xqt created this task.Feb 13 2014, 1:46 PM

Aklapper added a project: Pywikibot.Nov 27 2014, 4:18 PM

jayvdb triaged this task as High priority.Dec 26 2014, 5:47 AM

jayvdb updated the task description. (Show Details)

jayvdb edited projects, added Pywikibot-i18n; removed Pywikibot, TestMe.

jayvdb set Security to None.

jayvdb removed a subscriber: Unknown Object (????).

https://www.google-melange.com/gci/task/view/google/gci2014/5771021005094912

This is an good first task follow up to T59602 , as it is the same problem as T74733.

jayvdb moved this task from Backlog to pywikibot on the Google-Code-in-2014 board.Jan 15 2015, 1:16 AM

Sn1per claimed this task.Jan 18 2015, 1:06 AM

Change 185783 had a related patch set uploaded (by Sn1per):
Add unprotection messages

https://gerrit.wikimedia.org/r/185783

Patch-For-Review

Change 185784 had a related patch set uploaded (by Sn1per):
Use unprotect i18n messages

https://gerrit.wikimedia.org/r/185784

Patch-For-Review

Sn1per added a parent task: T87155: Unit tests for protect.py.Jan 18 2015, 10:45 PM

Sn1per added a subtask: T87124: protect.py only unprotects pages because it cannot properly determine which protection types are valid.

Change 185783 merged by jenkins-bot:
Add unprotection messages

https://gerrit.wikimedia.org/r/185783

Sn1per closed subtask T87124: protect.py only unprotects pages because it cannot properly determine which protection types are valid as Resolved.Jan 19 2015, 4:44 AM

Change 185784 merged by jenkins-bot:
Use unprotect i18n messages

https://gerrit.wikimedia.org/r/185784

Sn1per closed this task as Resolved.Jan 19 2015, 6:18 AM

jayvdb mentioned this in rPWIN3aa58d74d10f: Add unprotection messages.Mar 4 2015, 8:40 AM

Sn1per mentioned this in rPWBC6b796778ec9a: Updated pywikibot/core Project: pywikibot/i18n….Mar 4 2015, 8:46 AM

Sn1per mentioned this in rPWBC04b730b1b559: Use unprotect i18n messages.

Sn1per mentioned this in rPWBOa49acdb67507: Updated pywikibot/compat Project: pywikibot/i18n….Mar 4 2015, 8:53 AM