Page MenuHomePhabricator

Upgrade python requests on tool labs
Closed, ResolvedPublic

Description

It looks like tool labs is using v1.1.0 of the Python package 'Requests' - this is grossly out of date (current is 2.2.1). There are a bunch of known SSL negotiation issues in older versions of Requests, and I suspect this is part of the problem being experienced by tools like Bingle and Bugello post-Bugzilla upgrade/migration. Can we please upgrade requests?

Details

Reference
bz61334

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:51 AM
bzimport added a project: Tools.
bzimport set Reference to bz61334.
bzimport added a subscriber: Unknown Object (MLST).

There are a fairly large number of tools that use requests, and it's not clear that both versions and cooexist peacefully. Do we know if/how much the API has changed between v1 and v2 and how likely it is than an upgrade would break other tools?

API changes from v1 to v2 are relatively minor:
http://www.python-requests.org/en/latest/api/#id1

It looks primarily like changes to the types of exceptions that may get raised, with the scariest looking thing being an update to the proxies API. I suspect this will be a fairly safe upgrade.

That, indeed, doesn't look overly disruptive. I'll make a deb of the more recent version.

Just wanted to dbl check on the status of this. Thanks!

Note that tool labs on eqiad has an even older version of the requests library, which has caused further breakage in my tools.

tools.bugello@tools-login:~$ python
Python 2.7.3 (default, Feb 27 2014, 19:58:35)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.

import requests
requests.version

'0.8.2'

scfc updated the task description. (Show Details)
scfc edited projects, added Toolforge; removed Tools.
scfc set Security to None.
scfc subscribed.

python-requests has been updated to 2.0.0 for Precise instances and 2.2.1 for Trusty ones.