Page MenuHomePhabricator

Bold sidebar and search results when searching on is.wikipedia.org
Closed, InvalidPublic

Description

Steps:

  1. Search for Module:Html, Module:Bold, Module:Italics, or other html markup with the prefix "Module:". (not case sensitive)
  2. The sidebar, all search results and the top bar become bold

Reproducable on en.wikipedia, test2.wikipedia, wikidata, and commons with CirrusSearch enabled in the beta settings on en.wiki and commons (CirrusSearch is enabled by default on wikidata and test2).

Expected behaviour: Only html tags and html text in search results should be in bold.


Version: unspecified
Severity: normal
Platform: PC
URL: https://is.wikipedia.org/w/index.php?title=Kerfissíða%3ALeit&profile=default&search=aspen&fulltext=Search

Details

Reference
bz61348

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:52 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz61348.
bzimport added a subscriber: Unknown Object (MLST).

I'm also unable to reproduce this behaviour.

snaevar: Browser info also welcome.

Please note that we will soon be closing this as RESOLVED WORKSFORME unless information is provided so that we can reproduce the problem.

Resolving worksforme since nobody can replicate. Feel free to reopen with more information.

I did some further investigating with the following findings:

  • I can repreduce this issue in firefox (newest version) on several windows xp sp3 machines.
  • On special:search, in the firefox inspector console I see two strong tags under p class="searchresults". I can also see two strong tags under div id="content" class="mw-body". Those four strong tags are the culprit.
  • The search word does not matter. Going to special:Search directly (without any search query) does not make the sidebar bold for me.
  • Configuring my personal common.css file to have font-weight:normal on .mw-search-results and #mw-navigation works for me as an workaround.

What is "firefox (newest version)" exactly? "Newest" highly depends on your update channels.
Plus did you manage to reproduce with any other browser? Which ones (and versions) did you test?

Plus an example URL is still welcome (and maybe a screenshot that does not expose any private/confidential information).

Created attachment 16128
bug 61348 search xp

Search results on winxp, firefox 31.0

Attached:

search.png (618×1 px, 70 KB)

By Firefox newest version I mean that I managed to reproduce the bug on several winxp machines with firefox 31.0.

I did manage to repreduce the bug on Internet Explorer 8.0.6001.18702 aswell. I did not test any other browsers.

I added an example url to the bug information (near the top of the page).

I can reproduce the problem with Firefox 31 on Fedora 20 (Linux) on is.wp.

For example, https://is.wikipedia.org/w/index.php?title=Kerfiss%C3%AD%C3%B0a%3ALeit&profile=default&search=aspen&fulltext=Search

There are some <strong> HTML elements in the source code but no idea where they are coming from - likely some on-wiki stuff...

Looks like it comes from this:
<strong>Skapaðu síðuna "<a href="/w/index.php?title=Aspen&amp;action=edit&amp;redlink=1" class="new" title="Aspen (síða er ekki enn til)">Aspen</a>" á þessum wiki!<strong>

Its a problem with the translation message. In is.json in core:
"searchmenu-new": "<strong>Skapaðu síðuna \"[[:$1]]\" á þessum wiki!<strong>\nSjá einnig {{PLURAL:$2|0=|leitarniðurstöðuna|leitarniðurstöðurnar}}.",

Gotta close that strong tag. I don't have translator rights or else I'd just go fix it.

Nik: Thanks so much for tracking this down!

Snævar: I'm closing this ticket as INVALID as this needs to be handled and fixed by Icelandic translators on https://translatewiki.net/wiki/MediaWiki:Searchmenu-new/is?action=edit .
It looks like the bug reporter (Snævar) has edited the string before.