Add {{Art Photo}} to the templates accepted by the GWtoolset
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	JeanFred
	Feb 14 2014, 2:22 PM

Description

{{Art Photo}} is a combination of {{Artwork}} and {{Photograph}}. It is very useful for photographs of 3D museum objects.

Please add {{Art Photo}} to the GWToolset configuration.

(It is my understanding that the GWToolset infers all its config from TemplateData − if so, I can submit a patch for this).

Version: unspecified
Severity: normal
URL: https://commons.wikimedia.org/wiki/Template:Art_Photo

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:54 AM

• bzimport set Reference to bz61376.

• bzimport added a subscriber: Unknown Object (MLST).

Change 113369 had a related patch set uploaded by Dan-nl:
add Art Photo template to GWToolset

GWToolset currently uses includes/Config.php to determine which templates are allowed. a “fallback” json represents the template, but if a TemplateData version is available it will prefer that.
i have added the fallback json to the includes/Config.php and added you as a reviewer. once merged, it will appear on the beta cluster.

Thanks Dan for the explanation − and the patch which I slightly amended. Looks good to me!

In the mean time I enabled TemplateData on {{Art Photo}} (isn't it possible to inherit it from {{Artwork}} & {{Photograph}}? would save some hassle).

Change 113369 merged by Dan-nl:
add Art Photo template to GWToolset

Jean-Fred, this has been done. Do you want to close the ticket?

Sure. Closed as fixed.

• Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:23 AM