Page MenuHomePhabricator
Create Task
Maniphest T63443

Enable gzip transfer encoding for png and ico files in /static
Closed, ResolvedPublic
Actions

Description

Our favicon .ico files have gotten larger recently with a bump in resolution and color/alpha depth. While they look great, they've also expanded from a couple kb to for instance 15kb for Wikipedia:

https://en.wikipedia.org/static/favicon/wikipedia.ico

These .ico files gzip very well, however (they're either uncompressed or simple run-length encoding bitmaps, as I recall) and gzip takes that file back down to 2.5kb nicely.

Having the web server auto-gzip the .ico files might be a nice small bandwidth savings, especially on mobile networks.

Details

Reference
bz61443
SubjectRepoBranchLines +/-
Fix ICO MIME regexpsoperations/puppetproduction+3 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
• bzimport added a project: Wikimedia-Apache-configuration.
• bzimport set Reference to bz61443.
• bzimport added a subscriber: Unknown Object (MLST).
• brion created this task.Feb 16 2014, 6:56 PM
gerritbot added a comment.Feb 16 2014, 6:59 PM

Change 113687 had a related patch set uploaded by Brion VIBBER:
Work in progress: set .svg and .ico files to be compressed on bits.wikimedia.org

https://gerrit.wikimedia.org/r/113687

Krinkle renamed this task from Apply gzip transfer encoding to ICO files from bits.wikimedia.org (favicon.ico) to Enable gzip transfer encoding for png and ico files in /static.Jul 2 2015, 3:46 AM
Krinkle updated the task description. (Show Details)
Krinkle edited projects, added Varnish, Performance-Team; removed Patch-For-Review, Wikimedia-Apache-configuration.
Krinkle set Security to None.
Krinkle removed a subscriber: • wikibugs-l-list.
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jul 2 2015, 5:21 AM
Krinkle moved this task from Backlog: Maintenance, non-prioritized to To-do: Goals prioritized current Quarter on the Performance-Team board.
Krinkle added subscribers: • Gilles, ori.Jul 8 2015, 7:07 AM
• Gilles added a comment.Jul 20 2015, 9:01 AM

Maybe this was solved at some point, but I see these static images served ungzipped at the moment:

https://en.wikipedia.org/static/favicon/wikipedia.ico
https://en.wikipedia.org/static/images/wikimedia-button.png

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2015, 9:01 AM
• Gilles added a comment.Jul 20 2015, 9:13 AM

TIL that since gzipping compressed formats like PNGs is pointless, we usually have rules only applying it to icos and SVGs. In the case of the wikipedia favicon there is 1-2kb to save here.

• Gilles added a comment.Jul 20 2015, 9:21 AM

I'm not sure what the current relationship between /static/ and bits is, but I saw this tidbit in bits that I think explains it, at least in terms of wrong assumption:

https://github.com/wikimedia/operations-puppet/blob/production/templates/varnish/bits.inc.vcl.erb#L87

The favicon is currently served with this MIME type: image/vnd.microsoft.icon which means that it doesn't mach the regexp. It's quite certainly the wrong codepath for /static/, though, but it explains why https://bits.wikimedia.org/favicon/wikipedia.ico is equally ungzipped.

I can't find any SVGs in /static/, so icos should probably be the focus of the fix.

gerritbot subscribed.Jul 20 2015, 9:26 AM

Change 225852 had a related patch set uploaded (by Gilles):
Fix ICO MIME regexps

https://gerrit.wikimedia.org/r/225852

gerritbot added a project: Patch-For-Review.Jul 20 2015, 9:26 AM
• Gilles claimed this task.Jul 20 2015, 9:26 AM
• Gilles moved this task from To-do: Goals prioritized current Quarter to Doing (old) on the Performance-Team board.
gerritbot added a comment.Jul 27 2015, 5:52 PM

Change 225852 merged by BBlack:
Fix ICO MIME regexps

https://gerrit.wikimedia.org/r/225852

BBlack mentioned this in rOPUPba5f8ae82718: Fix ICO MIME regexps.Jul 27 2015, 5:52 PM
• Gilles closed this task as Resolved.Jul 28 2015, 8:09 AM

Works, although the icons that are already stored in varnish remain ungzipped, because they were cached that way. Adding a cache-busting parameter makes the fix visible: https://en.wikipedia.org/static/favicon/wikipedia.ico?2

Aklapper added a project: Traffic.May 4 2016, 9:14 AM
Restricted Application added a project: SRE. · View Herald TranscriptMay 4 2016, 9:14 AM
Krinkle mentioned this in T232615: Enable gzip compression for interface icon SVGs served by MediaWiki.Sep 11 2019, 3:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL