Page MenuHomePhabricator

unusual behavior with Watchlist and Notifications causes browser test failure
Closed, ResolvedPublic

Description

URL shows Watchlist but page is Notifications

This behavior seen as of Feb 17. I have not created a manual repro, but it could possibly be done.

This seems to be a new issue affecting Chrome but not Firefox.

To see the issue in a local environment:

export MEDIAWIKI_USER=
export MEDIAWIKI_PASSWORD=
export MEDIAWIKI_URL=http://en.m.wikipedia.beta.wmflabs.org/wiki/
export KEEP_BROWSER_OPEN=true
export BROWSER_LABEL=chrome

bundle exec cucumber features/notification.feature:15

The test reports:

When I click the browser back button                            # features/step_definitions/common_steps.rb:113
Then after 1 seconds I should not see the notifications overlay # features/step_definitions/notification_steps.rb:13
  expected visible? to return false, got true (RSpec::Expectations::ExpectationNotMetError)

The root issue is that the back button is available before the notifications page manifests and the test clicks it, so that while Chrome displays the notification page, the URL Chrome shows is actually already back on Watchlist.

This seems unlikely to affect a user, and I checked in a fix for the test, but I wanted to document it.


Version: unspecified
Severity: minor

Attached:

url_on_notifications_page_does_not_have_notifications.png (687×983 px, 67 KB)

Details

Reference
bz61504

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:03 AM
bzimport set Reference to bz61504.
bzimport added a subscriber: Unknown Object (MLST).

Change 113997 had a related patch set uploaded by Cmcmahon:
See Bug 61504 for description

https://gerrit.wikimedia.org/r/113997

Change 113997 merged by jenkins-bot:
Maintenance for Chrome race condition. See Bug 61504 for description

https://gerrit.wikimedia.org/r/113997