Page MenuHomePhabricator
Create Task
Maniphest T63526

InputBox should use Mediawiki.ui
Closed, ResolvedPublic
Actions

Description

InputBox is widely used for (slightly) interactive workflows on many wikis. Now that we have a standard house style for buttons in the form of the mw-ui-button styles (default, progressive, constructive and destructive styles), we should make these widely-used InputBox buttons use them.

http://tools.wmflabs.org/styleguide/desktop/section-2.html

Per the style guide, probably the two search types (search, fulltext, search2) should use the default white Agora style, while the others which open an edit window for a new page or addition to an existing page (create, comment, commenttitle) should use the progressive style.

Version: unspecified
Severity: normal

Details

Reference
bz61526
SubjectRepoBranchLines +/-
Hygiene: Use MediaWiki-UI for all elementsmediawiki/extensions/InputBoxmaster+16 -10
Update inputs to use mw-ui stylesmediawiki/extensions/InputBoxmaster+17 -13
Update buttons to use mw-ui stylesmediawiki/extensions/InputBoxmaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:04 AM
• bzimport added projects: MediaWiki-extensions-InputBox, good first task.
• bzimport set Reference to bz61526.
• bzimport added a subscriber: Unknown Object (MLST).
Ragesoss created this task.Feb 19 2014, 1:06 AM
• AKoval_WMF added a comment.Jun 4 2014, 5:07 PM

+1 to what Sage Ross said.

We're using inputboxes and mw-ui-buttons quite a lot now on the education portal on Outreach wiki, and it'd be better if they all looked the same: that is, pretty and new. :)

Currently an inputbox cannot be a progressive button as shown here:
http://tools.wmflabs.org/styleguide/desktop/section-3.html

We wish that this were possible. Hoping you can help.

Thanks!

• Jaredzimmerman-WMF updated the task description. (Show Details)Dec 2 2014, 11:14 PM
• Jaredzimmerman-WMF added a project: MediaWiki-MediaWiki-UI.
• Jaredzimmerman-WMF set Security to None.
Jdforrester-WMF edited projects, added UI-Standardization; removed MediaWiki-MediaWiki-UI.Dec 3 2014, 7:01 PM
gerritbot added a project: Patch-For-Review.Jan 7 2015, 11:39 PM

Change 183397 had a related patch set uploaded (by McIntireEvan):
Update buttons to use mw-ui styles

https://gerrit.wikimedia.org/r/183397

Patch-For-Review

whym subscribed.Jan 11 2015, 3:25 AM
gerritbot subscribed.Jan 30 2015, 10:59 PM

Change 183397 merged by jenkins-bot:
Update buttons to use mw-ui styles

https://gerrit.wikimedia.org/r/183397

McIntireEvan mentioned this in rEINB7ce80c51a5f0: Update buttons to use mw-ui styles.Jan 30 2015, 11:39 PM
Glaisher subscribed.Feb 11 2015, 4:49 AM

hm, why only the buttons? can we have 'mw-ui-input' in the text input as well?

Glaisher renamed this task from Input box buttons should use Mediawiki.ui button styles to InputBox should use Mediawiki.ui.Feb 11 2015, 4:50 AM
Glaisher removed a project: Patch-For-Review.
McIntireEvan subscribed.Feb 15 2015, 4:24 AM

If no one else does it before me, I'll work on this one I setup my dev environment again

gerritbot added a comment.Feb 23 2015, 2:55 AM

Change 192260 had a related patch set uploaded (by McIntireEvan):
Update inputs to use mw-ui styles

https://gerrit.wikimedia.org/r/192260

Patch-For-Review

Florian claimed this task.Feb 23 2015, 8:46 AM
gerritbot added a comment.Feb 23 2015, 8:47 AM

Change 192282 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Use MediaWiki-UI for all elements

https://gerrit.wikimedia.org/r/192282

Patch-For-Review

Florian added a comment.Feb 23 2015, 8:49 AM

The information page on mediawiki.org would look like:

result.PNG (802×1 px, 58 KB)

Florian added a project: Patch-For-Review.Feb 23 2015, 8:49 AM
gerritbot added a comment.Feb 23 2015, 2:43 PM

Change 192260 abandoned by McIntireEvan:
Update inputs to use mw-ui styles

Reason:
https://gerrit.wikimedia.org/r/#/c/192282/

https://gerrit.wikimedia.org/r/192260

Florian added a comment.Feb 23 2015, 3:32 PM

@McIntireEvan: sry, i didn't know, that you already had a change for it :/

McIntireEvan added a comment.Feb 23 2015, 3:41 PM

@Florian Don't worry about it, your change was better than mine and I learned some stuff from it so no harm done!

• Jaredzimmerman-WMF added a subscriber: • Prtksxna.Feb 23 2015, 6:05 PM
gerritbot added a comment.Feb 26 2015, 10:53 PM

Change 192282 merged by jenkins-bot:
Hygiene: Use MediaWiki-UI for all elements

https://gerrit.wikimedia.org/r/192282

Florian mentioned this in rEINB99277a4d0fea: Hygiene: Use MediaWiki-UI for all elements.Feb 26 2015, 10:53 PM
Florian closed this task as Resolved.Feb 27 2015, 5:39 AM
Diffusion mentioned this in rMEXT15f0b6a72c50: Updated mediawiki/extensions Project: mediawiki/extensions/InputBox….Mar 11 2015, 6:25 AM
Diffusion mentioned this in rMEXTd46a89ab760b: Updated mediawiki/extensions Project: mediawiki/extensions/InputBox….Mar 11 2015, 6:27 AM
Glaisher mentioned this in T92348: inputbox width= values ignored.Mar 11 2015, 5:46 PM
FriedhelmW mentioned this in T92498: size of <inputbox> cannot be set under a certain limit.Mar 13 2015, 6:39 AM
Danny_B moved this task from Unsorted to mediawiki.ui on the UI-Standardization board.May 20 2016, 9:02 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 20 2016, 9:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL