jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Version: master
Severity: normal
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add jshint and jscs test to npm | mediawiki/extensions/CheckUser | master | +72 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Paladox | T62619 All repositories should pass jshint test | |||
| Resolved | Krenair | T63589 CheckUser should pass jshint |
Wtf? Somehow, when that patch was uploaded, we got:
https://integration.wikimedia.org/ci/job/mwext-CheckUser-jslint/56/console : SUCCESS in 8s (non-voting)
But then when merging:
https://integration.wikimedia.org/ci/job/mwext-CheckUser-jslint/57/console : FAILURE in 2s (non-voting)
Change 147744 had a related patch set uploaded by Alex Monk:
Reformat modules/ext.checkuser.cidr.js, fix some jshint errors
Change 147744 merged by jenkins-bot:
Reformat modules/ext.checkuser.cidr.js, fix some jshint errors
Change 225149 had a related patch set uploaded (by Hashar):
Add jshint and jscs test to npm
https://gerrit.wikimedia.org/r/#/c/225149/ add the npm integration
https://gerrit.wikimedia.org/r/#/c/225182/ makes it voting