Page MenuHomePhabricator

CleanChanges should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61590

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:50 AM
bzimport set Reference to bz61590.
bzimport added a subscriber: Unknown Object (MLST).

The job is failing though:

http://integration.wikimedia.org/ci/job/mwext-CleanChanges-jslint/

I guess it is because there is no jshintrc and hence it fallback to the default one we provide (bug 52456).

Change 114471 had a related patch set uploaded by Hashar:
Ensure jshint uses default settings

https://gerrit.wikimedia.org/r/114471

Due to bug 52456, we have to ship an empty .jshintrc file. The job pass now :-]

Change 114471 merged by jenkins-bot:
Ensure jshint uses default settings

https://gerrit.wikimedia.org/r/114471

Change 114472 had a related patch set uploaded by Hashar:
mwext-CleanChanges-jslint is now voting

https://gerrit.wikimedia.org/r/114472

Change 114472 merged by jenkins-bot:
mwext-CleanChanges-jslint is now voting

https://gerrit.wikimedia.org/r/114472

jshint is passing and the job is now voting :-]