Page MenuHomePhabricator
Create Task
Maniphest T63594

Collection should pass jshint
Closed, ResolvedPublic
Actions

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Details

Reference
bz61594
SubjectRepoBranchLines +/-
Remove non-voting property of mwext-Collection-jslintintegration/configmaster+0 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedPaladoxT62619 All repositories should pass jshint test
 ResolvedKrinkleT63594 Collection should pass jshint

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
• bzimport added a project: Collection.
• bzimport set Reference to bz61594.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Feb 20 2014, 1:27 PM
gerritbot subscribed.Mar 17 2015, 5:40 PM

Change 197365 had a related patch set uploaded (by Krinkle):
Add jshintrc file and make JSHint pass

https://gerrit.wikimedia.org/r/197365

gerritbot added a project: Patch-For-Review.Mar 17 2015, 5:40 PM
gerritbot added a comment.Mar 17 2015, 5:49 PM

Change 197371 had a related patch set uploaded (by Krinkle):
Remove non-voting property of mwext-Collection-jslint

https://gerrit.wikimedia.org/r/197371

gerritbot added a comment.Mar 17 2015, 5:50 PM

Change 197371 merged by jenkins-bot:
Remove non-voting property of mwext-Collection-jslint

https://gerrit.wikimedia.org/r/197371

Krinkle closed this task as Resolved.Mar 17 2015, 5:55 PM
Krinkle claimed this task.
Krinkle updated the task description. (Show Details)
Krinkle removed a project: Patch-For-Review.
Krinkle set Security to None.
Krinkle edited subscribers, added: cscott; removed: gerritbot, Unknown Object (MLST).
Krinkle mentioned this in rCICF96e4564c86bb: Remove non-voting property of mwext-Collection-jslint.Mar 23 2015, 3:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL