Page MenuHomePhabricator

ConfirmEdit should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
bzimport set Reference to bz61597.

Change 121573 had a related patch set uploaded by AalekhN:
Confirm Edit now passes jslint, so make it voting

https://gerrit.wikimedia.org/r/121573

Change 121573 abandoned by Hashar:
Confirm Edit now passes jslint, so make it voting

Reason:
ConfirmEdit does not pass jshint for me and dies out with 86 errors. Please get the javascript updated in mediawiki/extensions/ConfirmEdit.git then reopen this change :]

https://gerrit.wikimedia.org/r/121573

Change 122126 had a related patch set uploaded by AalekhN:
ConfirmEdit should pass jshint

https://gerrit.wikimedia.org/r/122126

Legoktm assigned this task to Paladox.
Legoktm set Security to None.
Legoktm subscribed.

From what I can see this was fixed by rECOE1b18e91eafb9: Add .jshintrc

Change 214292 had a related patch set uploaded (by Legoktm):
Make jshint and jsonlint voting for ConfirmEdit

https://gerrit.wikimedia.org/r/214292

Change 214292 merged by jenkins-bot:
Make jshint and jsonlint voting for ConfirmEdit

https://gerrit.wikimedia.org/r/214292