Page MenuHomePhabricator

ContributionTracking should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
bzimport set Reference to bz61599.
bzimport added a subscriber: Unknown Object (MLST).

Change 262703 had a related patch set uploaded (by Hashar):
Pass jshint and add it to 'npm test' command

https://gerrit.wikimedia.org/r/262703

Change 262704 had a related patch set uploaded (by Hashar):
Add jsonlint to npm test command

https://gerrit.wikimedia.org/r/262704

Change 262705 had a related patch set uploaded (by Hashar):
[ContributionTracking] drop jslint job (uses npm)

https://gerrit.wikimedia.org/r/262705

Change 262705 abandoned by Hashar:
[ContributionTracking] drop jslint job (uses npm)

Reason:
Squashed in https://gerrit.wikimedia.org/r/262708

https://gerrit.wikimedia.org/r/262705

Change 262703 merged by Ejegg:
Pass jshint and add it to 'npm test' command

https://gerrit.wikimedia.org/r/262703

Change 262704 merged by jenkins-bot:
Add jsonlint to npm test command

https://gerrit.wikimedia.org/r/262704

jshint / jsonlint are now run via npm.