Page MenuHomePhabricator
Create Task
Maniphest T63601

DataTypes should pass jshint
Closed, InvalidPublic
Actions

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Version: master
Severity: normal

Details

Reference
bz61601
SubjectRepoBranchLines +/-
Remove DataTypes mw extensionintegration/configmaster+0 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
• bzimport added projects: DataTypes, patch-welcome.
• bzimport set Reference to bz61601.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Feb 20 2014, 1:31 PM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:53 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
adrianheine closed this task as Invalid.Mar 12 2015, 11:13 AM
adrianheine claimed this task.
adrianheine subscribed.

We don't use the DataTypes project on gerrit currently.

Ricordisamoa subscribed.Mar 15 2015, 9:22 AM
hashar added a comment.Mar 17 2015, 1:26 PM

@adrianheine should we delete in Gerrit the mediawiki/extensions/DataTypes repository ?

gerritbot subscribed.Mar 17 2015, 1:28 PM

Change 197317 had a related patch set uploaded (by Hashar):
Remove DataTypes mw extension

https://gerrit.wikimedia.org/r/197317

gerritbot added a project: Patch-For-Review.Mar 17 2015, 1:28 PM
gerritbot added a comment.Mar 17 2015, 3:08 PM

Change 197317 merged by jenkins-bot:
Remove DataTypes mw extension

https://gerrit.wikimedia.org/r/197317

hashar added a comment.Mar 17 2015, 3:14 PM

It is out of CI now.

adrianheine added a comment.Mar 19 2015, 8:03 AM
In T63601#1125148, @hashar wrote:

@adrianheine should we delete in Gerrit the mediawiki/extensions/DataTypes repository ?

Yeah, we should. It doesn't even mirror the current HEAD.

hashar mentioned this in T93171: [Task] Delete mediawiki/extensions/DataTypes from Gerrit.EditedMar 19 2015, 8:20 AM
In T63601#1131109, @adrianheine wrote:
In T63601#1125148, @hashar wrote:

@adrianheine should we delete in Gerrit the mediawiki/extensions/DataTypes repository ?

Yeah, we should. It doesn't even mirror the current HEAD.

Thanks! I have filled T93171: [Task] Delete mediawiki/extensions/DataTypes from Gerrit :)

Lydia_Pintscher changed the status of subtask T93171: [Task] Delete mediawiki/extensions/DataTypes from Gerrit from Open to Stalled.Mar 19 2015, 9:58 AM
hashar mentioned this in rCICF9829d35fcf78: Remove DataTypes mw extension.Mar 23 2015, 3:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL