Maniphest T63602

DismissableSiteNotice should pass jshint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Feb 20 2014, 1:32 PM

Tags

Referenced Files

None

Subscribers

• wikibugs-l-list

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Version: master
Severity: normal

Details

Reference: bz61602

	Subject	Repo	Branch	Lines +/-
	Have DismissableSiteNotice pass jshint	mediawiki/extensions/DismissableSiteNotice	master	+32 -2
	Make jslint voting on ext DismissableSiteNotice	integration/config	master	+0 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Paladox	T62619 All repositories should pass jshint test
		Resolved		JanZerebecki	T63602 DismissableSiteNotice should pass jshint

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM

• bzimport added a project: DismissableSiteNotice.

• bzimport set Reference to bz61602.

• bzimport added a subscriber: Unknown Object (MLST).

hashar created this task.Feb 20 2014, 1:32 PM

Ricordisamoa subscribed.Jul 19 2015, 5:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 5:37 AM

Change 231690 had a related patch set uploaded (by TheDJ):
Have DismissableSiteNotice pass jshint

https://gerrit.wikimedia.org/r/231690

gerritbot added a project: Patch-For-Review.Aug 14 2015, 8:57 PM

Change 231690 merged by jenkins-bot:
Have DismissableSiteNotice pass jshint

https://gerrit.wikimedia.org/r/231690

TheDJ mentioned this in rMEXTbfb1677b2c41: Updated mediawiki/extensions Project….Sep 1 2015, 1:40 PM

• Forrestbot added a project: WMF-deploy-2015-09-01_(1.26wmf21).Sep 1 2015, 2:00 PM

TheDJ mentioned this in rEDSN396245f06023: Have DismissableSiteNotice pass jshint.Sep 1 2015, 2:02 PM

Change 235280 had a related patch set uploaded (by TheDJ):
Configure Dismissable Sitenotice with npm

https://gerrit.wikimedia.org/r/235280

Change 235280 merged by jenkins-bot:
Make jslint voting on ext DismissableSiteNotice

https://gerrit.wikimedia.org/r/235280

JanZerebecki mentioned this in rCICF2f9745edef14: Make jslint voting on ext DismissableSiteNotice.Sep 2 2015, 1:11 PM

Job is now voting, see jenkins comment on: https://gerrit.wikimedia.org/r/#/c/231690/