Page MenuHomePhabricator

InputBox should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61606

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
bzimport set Reference to bz61606.
bzimport added a subscriber: Unknown Object (MLST).

Change 120487 had a related patch set uploaded by 01tonythomas:
Adding a JS Class to inputBox to grey out Submit button.

https://gerrit.wikimedia.org/r/120487

(In reply to Antoine "hashar" Musso from comment #0)
What does JSHINT complain about and *where*? There is not a single JavaScript file in the repo currently [1]. Only JSON. Please be more specific.

[1] https://github.com/wikimedia/mediawiki-extensions-InputBox/tree/b85c6688

Change 125393 had a related patch set uploaded by Hashar:
Make mwext-InputBox-jslint voting

https://gerrit.wikimedia.org/r/125393

Change 125393 merged by jenkins-bot:
Make mwext-InputBox-jslint voting

https://gerrit.wikimedia.org/r/125393

(In reply to Rainer Rillke @commons.wikimedia from comment #2)

What does JSHINT complain about and *where*? There is not a single
JavaScript file in the repo currently [1]. Only JSON. Please be more
specific.

[1] https://github.com/wikimedia/mediawiki-extensions-InputBox/tree/b85c6688

I have mass filled bugs for any extension that had the jslint job not voting. I havent looked closely at each extension :-]

Since there is no javascript I have made the jslint job voting. The job also lint the i18n json files :-]

Thanks for the feedback!

Change 120487 merged by jenkins-bot:
Adding a JS Class to inputBox to grey out Submit button.

https://gerrit.wikimedia.org/r/120487