Page MenuHomePhabricator
Create Task
Maniphest T63608

LastModified should pass jshint
Closed, ResolvedPublic
Actions

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Version: master
Severity: normal

Details

Reference
bz61608
SubjectRepoBranchLines +/-
Fix jslint errors, And also add npm entry pointmediawiki/extensions/LastModifiedmaster+81 -13
[LastModified] Replace jslint test with jsonlint and jshint testsintegration/configmaster+2 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedPaladoxT62619 All repositories should pass jshint test
 ResolvedPaladoxT63608 LastModified should pass jshint

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:51 AM
• bzimport added a project: LastModified.
• bzimport set Reference to bz61608.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Feb 20 2014, 1:37 PM
Aklapper triaged this task as Lowest priority.Jan 21 2015, 5:33 AM
Aklapper subscribed.
Hydriz subscribed.Feb 21 2015, 1:05 AM
gerritbot subscribed.Feb 18 2016, 3:09 PM

Change 271526 had a related patch set uploaded (by Paladox):
Fix jslint errors

https://gerrit.wikimedia.org/r/271526

gerritbot added a project: Patch-For-Review.Feb 18 2016, 3:09 PM
gerritbot added a comment.Feb 18 2016, 3:11 PM

Change 271528 had a related patch set uploaded (by Paladox):
[LastModified] Replace jslint test with jsonlint and jshint tests

https://gerrit.wikimedia.org/r/271528

hashar assigned this task to Paladox.Feb 18 2016, 9:10 PM
gerritbot added a comment.Feb 19 2016, 1:14 PM

Change 271528 merged by Hashar:
[LastModified] Replace jslint test with jsonlint and jshint tests

https://gerrit.wikimedia.org/r/271528

hashar closed this task as Resolved.Feb 19 2016, 1:29 PM
hashar added a subscriber: Paladox.
gerritbot added a comment.Feb 23 2016, 9:23 AM

Change 271526 merged by jenkins-bot:
Fix jslint errors, And also add npm entry point

https://gerrit.wikimedia.org/r/271526

Hydriz moved this task from Backlog to Completed on the LastModified board.Oct 15 2016, 10:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL