Page MenuHomePhabricator

[upstream] Maps should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61611

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61611.
bzimport added a subscriber: Unknown Object (MLST).

Jeroen: What's the reason to be actively against fixing this (WONTFIX)?

I do not interpret WONTFIX as being against it being fixed. If someone submits a PR doing so, that'd be great. If someone creates a new ticket with this issue, then that is also fine. However pointing to this one would be odd since it has stuff that no longer applies.

one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

(In reply to Jeroen De Dauw from comment #2)

I do not interpret WONTFIX as being against it being fixed.

See [[mw:Bug management/Bug report life cycle]] for meanings; sounds like lowest priority then.

Reopening as lowest priority. That should be fixed.

The Maps issue tracker is at https://github.com/JeroenDeDauw/Maps/issues

Reopen it there if you care to.

Upstream bug: https://github.com/JeroenDeDauw/Maps/issues/28

(still can't believe how much time I am losing with you.

If you reopen, this this will jsut end up with having one open bug stick around forever. Now if you please can stop wasting my time by obstructing the migration of the bugs of the extension I created and maintain, that'd be very nice.