Page MenuHomePhabricator

MwEmbedSupport should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Update 21/10/2015

The file have been ignored so that we could change to using npm to test js files instead of jslint, jshint is kept for non-whitelisted users. so the files will need to be un ignored and js fixes added too.


Version: master
Severity: normal

Details

Reference
bz61613

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61613.
bzimport added a subscriber: Unknown Object (MLST).

I'd suggest lowering this to volunteer priority, but "low" should suffice...we may come around to this at some point.

Ive changed it so it ignore those files since it is an upstream repo. So the description should be fix the jshint errors and re enable the files to be tested again.

hashar claimed this task.
hashar reassigned this task from hashar to Paladox.