Page MenuHomePhabricator

OATHAuth should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61617

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61617.

These look like upstream files... Do we just want to exclude those from the checks?

Apparently modules/qrcode.js is a third party file so it could be added to .jshintignore

modules/jquery.qrcode.js seems to have been written by Ryan Lane.

Change 148059 had a related patch set uploaded by Hashar:
Pass jshint

https://gerrit.wikimedia.org/r/148059

Change 148963 had a related patch set uploaded by Hashar:
Make OATHAuth jslint job voting

https://gerrit.wikimedia.org/r/148963

Change 148963 merged by jenkins-bot:
Make OATHAuth jslint job voting

https://gerrit.wikimedia.org/r/148963

Jenkins job is now voting. \O/