Page MenuHomePhabricator

RSS should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61621

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61621.

(In reply to Antoine "hashar" Musso from comment #0)

jshint reports failure on javascript files and should be fixed. Whenever
this is done, one can make the jslint job to be voting by editing
integration/zuul-config.git layout.yaml file and remove the line that make
the jslint job to be non voting.

Can you give send me link, or screenshot, what exactly you mean ?

"hashar": let me know, what is wrong and I will fix it as soon as possible !! !!!

Change 114526 had a related patch set uploaded by Hashar:
mwext-RSS-jslint has no .js, make it voting

https://gerrit.wikimedia.org/r/114526

Change 114526 merged by jenkins-bot:
mwext-RSS-jslint has no .js, make it voting

https://gerrit.wikimedia.org/r/114526

The RSS extensions has no javascript file, hence the Jenkins job http://integration.wikimedia.org/ci/job/mwext-RSS-jslint/? (which runs jshint) never got triggered.

I made it to vote, so whenever a Javascript file is added and does not pass jshint it will vote Verified -1.

Thank you and sorry for the trouble.