Page MenuHomePhabricator
Create Task
Maniphest T63630

SemanticForms should pass jshint
Closed, ResolvedPublic
Actions

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Version: master
Severity: normal

Details

Reference
bz61630

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
• bzimport added a project: MediaWiki-extensions-Page_Forms.
• bzimport set Reference to bz61630.
hashar created this task.Feb 20 2014, 1:46 PM
gerritbot added a comment.Aug 5 2014, 9:09 PM

Change 151970 had a related patch set uploaded by Jatin:
Making SF pass JSHint test

https://gerrit.wikimedia.org/r/151970

gerritbot added a comment.Aug 15 2014, 1:27 PM

Change 151970 merged by Yaron Koren:
Making SF pass JSHint test

https://gerrit.wikimedia.org/r/151970

Yaron_Koren added a comment.Aug 15 2014, 1:51 PM

hashar - can you confirm if this is now fixed?

gerritbot added a comment.Sep 16 2014, 10:13 AM

Change 160623 had a related patch set uploaded by Hashar:
SemanticForms now pass jshint make it voting

https://gerrit.wikimedia.org/r/160623

gerritbot added a comment.Sep 16 2014, 10:14 AM

Change 160623 merged by jenkins-bot:
SemanticForms now pass jshint make it voting

https://gerrit.wikimedia.org/r/160623

hashar added a comment.Sep 16 2014, 10:15 AM

Thanks Yaron! It even has a .jshintrc file.

I have made the Jenkins job voting :-)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL