Page MenuHomePhabricator

SemanticFormsInputs should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61631

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz61631.

Change 121679 had a related patch set uploaded by Jatin:
making js files pass jshint

https://gerrit.wikimedia.org/r/121679

Hi Antoine "hashar" Musso,

I have submitted a patch to this bug, please review the changes and validate them.

My Javascript is very limited, you might want to add as reviewers folks that write the code / maintain the extension :-)

Change 121679 merged by Foxtrott:
making js files pass jshint test

https://gerrit.wikimedia.org/r/121679

Change 160962 had a related patch set uploaded by Hashar:
SemanticFormsInputs pass jshint, make it voting

https://gerrit.wikimedia.org/r/160962

Change 160962 merged by jenkins-bot:
SemanticFormsInputs pass jshint, make it voting

https://gerrit.wikimedia.org/r/160962

I have updated Zuul to -2 whenever jshint is not passing. Thank you!