Page MenuHomePhabricator

SemanticResultFormats should pass jshint
Closed, DeclinedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: minor

Details

Reference
bz61634

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz61634.
bzimport added a subscriber: Unknown Object (MLST).
Unknown Object (User) added a comment.Feb 20 2014, 1:57 PM

I'm guessing this will not happen soon as there are several external libraries used and while those can be exempted, someone obviously has to do this.

Unless a volunteer finds the time to dig through the resources and make an effort to clear up the jshint/jslint issues, it consequently means that those will probably persist for some time to come.

Seems third party libraries are ignored already:

$ cat .jshintignore

jQuery third-party libs

resources/jquery/

other third-party libs

formats/Exhibit
formats/JitGraph
formats/timeline/resources/SimileTimeline
$

That is a good start :-]

Aklapper subscribed.

The Semantic MediaWiki developers requested in https://phabricator.wikimedia.org/T64114 to move their task tracking to https://github.com/SemanticMediaWiki and to close remaining tasks in Wikimedia Phabricator. If you still face the problem reported in this task in a supported version of SMW, please feel free to transfer your report to https://github.com/SemanticMediaWiki/SemanticResultFormats/issues . We are sorry for the inconvenience.