Maniphest T63641

TwoFactorAuthentication should pass jshint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Feb 20 2014, 1:51 PM

Tags

Referenced Files

None

Subscribers

• wikibugs-l-list

Tokens

"Like" token, awarded by hashar.

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

Version: master
Severity: normal

Details

Reference: bz61641

	Subject	Repo	Branch	Lines +/-
	Enable jshint voting for TwoFactorAuthentication	integration/config	master	+0 -2
	TwoFactorAuthentication now pass jshint	integration/config	master	+0 -2
	Fix jshint errors	mediawiki/extensions/TwoFactorAuthentication	master	+112 -89

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Paladox	T62619 All repositories should pass jshint test
		Resolved		Sn1per	T63641 TwoFactorAuthentication should pass jshint

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM

• bzimport added a project: MediaWiki-extensions-TwoFactorAuthentication.

• bzimport set Reference to bz61641.

• bzimport added a subscriber: Unknown Object (MLST).

hashar created this task.Feb 20 2014, 1:51 PM

Aklapper triaged this task as Lowest priority.Jan 21 2015, 12:45 AM

Aklapper subscribed.

I will try to do this one :)

Change 186138 had a related patch set uploaded (by Sn1per):
Fix jshint errors

https://gerrit.wikimedia.org/r/186138

Patch-For-Review

Change 186141 had a related patch set uploaded (by Sn1per):
Enable jshint voting for TwoFactorAuthentication

https://gerrit.wikimedia.org/r/186141

Patch-For-Review

Change 186138 merged by jenkins-bot:
Fix jshint errors

https://gerrit.wikimedia.org/r/186138

Change 190370 had a related patch set uploaded (by Hashar):
TwoFactorAuthentication now pass jshint

https://gerrit.wikimedia.org/r/190370

Patch-For-Review

Change 190370 merged by jenkins-bot:
TwoFactorAuthentication now pass jshint

https://gerrit.wikimedia.org/r/190370

hashar mentioned this in rCICF3f495182bf2e: TwoFactorAuthentication now pass jshint.Feb 12 2015, 10:52 PM

Fixed by @Sn1per . I have configured CI to make jshint voting.

hashar awarded a token.Feb 12 2015, 10:53 PM

hashar mentioned this in rETFAb2942f3698ea: Fix jshint errors.Feb 12 2015, 10:58 PM

Change 186141 abandoned by Sn1per:
Enable jshint voting for TwoFactorAuthentication

Reason:
Already merged in Ice579d626335b483b8fcd6380980723752a7379f :)

https://gerrit.wikimedia.org/r/186141

Sn1per mentioned this in rMEXT1b318eaa1545: Updated mediawiki/extensions Project….Mar 11 2015, 6:26 AM