Page MenuHomePhabricator

WikimediaEvents should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61646

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz61646.

Change 114500 had a related patch set uploaded by Mattflaschen:
Fix jshint by noting global requirement for VE file

https://gerrit.wikimedia.org/r/114500

Change 114500 merged by jenkins-bot:
Fix jshint by noting global requirement for VE file

https://gerrit.wikimedia.org/r/114500

Change 114519 had a related patch set uploaded by Mattflaschen:
Make jshint voting for WikimediaEvents

https://gerrit.wikimedia.org/r/114519

Change 114519 merged by jenkins-bot:
Make jshint voting for WikimediaEvents

https://gerrit.wikimedia.org/r/114519

Well done! Thank you very much :-]