Page MenuHomePhabricator

CommonsDelinker should not replace/remove images if a different version of the target exists locally
Closed, ResolvedPublic

Description

This issue was converted from https://jira.toolserver.org/browse/COMMONSDELINKER-19.
Summary: CommonsDelinker should not replace images if a different version of the target exists locally
Issue type: Bug - A problem which impairs or prevents the functions of the product.
Priority: Major
Status: Open
Assignee: Siebrand Mazeland <s.mazeland@xs4all.nl>


From: Ilmari Karonen <nospam@vyznev.net>

Date: Thu, 14 Oct 2010 14:01:37

CommonsDelinker should not carry out replacements if the local wiki has a different image by the same name as the target.

For an example of this happening, see this diff where CommonsDelinker replaced commons:File:Nepenthes boschiana-2.jpg with en:File:Nepenthes boschiana.jpg (instead of the intended commons:File:Nepenthes boschiana.jpg).


Version: unspecified
Severity: major

Details

Reference
bz61656

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:54 AM
bzimport set Reference to bz61656.
bzimport added a subscriber: Unknown Object (MLST).

From: Ilmari Karonen <nospam@vyznev.net>

Date: Thu, 14 Oct 2010 14:26:11

Ps. I've reverted the replacement I used as an example above and moved the en.wp image to Commons. At the time the replacement happened, File:Nepenthes_boschiana.jpg and File:Nepenthes_boschiana-2.jpg were identical on Commons, and the photo now at commons:File:Nepenthes_boschiana.jpg was at the same title on en.wp.

For the record: There is a complaint about this at [[c:COM:AN#Bot User:CommonsDelinker and Voting booth]].

If an image is deleted on Commons, the bot goes around and removes all files with that name from all projects.
(copy from an)

(In reply to Steinsplitter from comment #3)

If an image is deleted on Commons, the bot goes around and removes all files
with that name from all projects.
(copy from an)

See also [[Wikipedia:Bots/Requests for approval/Commons fair use upload bot 2]] (quoted text written by [[User:Dcoetzee]] / [[WP:CC-BY-SA]]):

I should note that, due to a bug in User:CommonsDelinker, images will still be
removed from articles when they are deleted from Commons even if they have been
reuploaded here using Commons fair use upload bot. I just looked up the old
thread in which I contacted the bot manager and they said "I cannot fix that.
Patches for CommonsDelinker are appreciated. The code is in pywikipediabot's
svn.". So there is a possibility they might accept a patch for this.

Commons fair use upload bot now reverts edits by CommonsDelinker that are
affected by the redirect bug, including the cases affecting Commons fair use
upload bot's re-uploaded files. It would still be preferable to fix
CommonsDelinker if we can find a way to do this, but so far I haven't been able
to get in touch with anyone who can help me do that.

Steinsplitter closed this task as Resolved.EditedJan 20 2015, 4:45 PM
Steinsplitter claimed this task.

https://bitbucket.org/magnusmanske/commons-delinquent/src/75a8d483e7950b90e10b6aff0a95bc7f8cd9f2d6/demon.php?at=master LINE 92 (function fileExistenceSanityCheck)

Seems like Magnus fixed this bug when rewriting the bot.

Steinsplitter set Security to None.