Page MenuHomePhabricator

FlaggedRevs git master doesn't work in MediaWiki < 1.23
Closed, InvalidPublic

Description

In https://gerrit.wikimedia.org/r/103936 SpecialPage::getTitle was replaced with getPageTitle . getPageTitle was introduced in 1.23 breaking backward compatibility with 1.22 and lower (see https://doc.wikimedia.org/mediawiki-core/master/php/html/classSpecialPage.html#a04aacd5fbbe67c5d47fe76eab1f0e538)

So on my local wiki with 1.22.0 (6071399) + Flagged Revisions (ed2ea20)
21:41, 6 February 2014 (https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FFlaggedRevs.git/ed2ea203ee3c40b01db5af5d4249729fc3645a39) I get a nice error:

[b2c58233] /wiki/Special:AdvancedReviewLog Exception from line 376 of /data/var/www/html/w/includes/SpecialPage.php: Call to undefined method QualityOversight::getPageTitle

Backtrace:

#0 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(75): SpecialPage->__call(string, array)
#1 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(75): QualityOversight->getPageTitle()
#2 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(51): QualityOversight->showForm()
#3 /data/var/www/html/w/includes/SpecialPage.php(631): QualityOversight->execute(NULL)
#4 /data/var/www/html/w/includes/SpecialPageFactory.php(488): SpecialPage->run(NULL)
#5 /data/var/www/html/w/includes/Wiki.php(298): SpecialPageFactory::executePath(Title, RequestContext)
#6 /data/var/www/html/w/includes/Wiki.php(602): MediaWiki->performRequest()
#7 /data/var/www/html/w/includes/Wiki.php(467): MediaWiki->main()
#8 /data/var/www/html/w/index.php(49): MediaWiki->run()
#9 {main}


Version: REL1_22-branch
Severity: normal

Details

Reference
bz61666

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:55 AM
bzimport set Reference to bz61666.
bzimport added a subscriber: Unknown Object (MLST).

It is a long-established tradition that master versions of most extensions are only compatible with master MW, so I see no problem here unless there's a specific pledge from its developers to maintain backwards compatibility.

I agree Max, but check out https://www.mediawiki.org/wiki/MediaWiki . The current stable release of mediawiki is 1.22.2. We should at least support that.

And there's LTS 1.19 which is also supported. But you should use respective branches for them.

(In reply to Maarten Dammers from comment #0)

So on my local wiki with 1.22.0 (6071399) + Flagged Revisions (ed2ea20)

But ed2ea20 is git master, it seems. You filed this ticket against FlaggedRevs and set the version field to "REL1_22 branch" which is confusing.

For MediaWiki 1.22, the FlaggedRevs "REL1_22" branch is meant to be used.