Page MenuHomePhabricator

Raw edit links on file description pages
Closed, ResolvedPublic

Details

Reference
bz61807

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:04 AM
bzimport set Reference to bz61807.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1723

The raw edit links actually will redirect to the appropriate editor.
They do look ugly and should be handled like every other link though.
What creates them exactly - it looks like some code specific to the magic commons code...

(In reply to Jon from comment #2)

The raw edit links actually will redirect to the appropriate editor.

No they will not - because they're leading to Commons. This happens because we process our own parse results to redo the edit links our way, however we can't influence whatever we're receiving from Commons. Let's just hide them with CSS.

No I understand what I am saying is if you are logged in on Commons
https://commons.m.wikimedia.org/w/index.php?title=File:Euromaidan_in_Kiev_2014-02-19_12-06.jpg&action=edit&section=2
will take you to the appropriate edit section. (try it)

What I am asking is what creates it. I suspect these are being generating in a hacky way and we can cut them off at the source.

See comment #3 for explanation. It makes a lot of sense to do just like core does and not show edit links from shared repo at all.

Change 115995 had a related patch set uploaded by MaxSem:
Suppress edit links from a remote repository on file pages

https://gerrit.wikimedia.org/r/115995

Change 115995 abandoned by MaxSem:
Suppress edit links from a remote repository on file pages

https://gerrit.wikimedia.org/r/115995

The links in question have been nuked per bug 19415.

Thanks Bartosz for updating this bug report!