If an item that is referenced in a claim of another item gets deleted, it is still shown as a link in that item. Instead it should be not linked and shown with a hint "deleted item".
This functionality broke (possibly) during the introduction of backend formatters for items.
Version: unspecified
Severity: critical
Whiteboard: u=dev c=backend p=13
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T63854 Don't link deleted items in the UI | |||
| Resolved | daniel | T64724 Reuse EntityInfoBuilder arrays when generating html (tracking) | |||
| Resolved | adrianheine | T75264 Refactor EntityView Instantiation | |||
| Resolved | daniel | T70022 Make formatter for referenced Items use pre-fetched labels. | |||
| Resolved | daniel | T70025 Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters. | |||
| Resolved | daniel | T70026 Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. | |||
| Resolved | daniel | T74308 Inject term lookup into formatters | |||
| Resolved | Wikidata-bugs | T75888 Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter |
This is a backend issue, since the frontend does not do any formatting on its own anymore.
The problem is doing this without asking the database about each link individually. We'll need to refactor EntityIdHtmlLinkFormatter and related classes so they can take information about the existance of an item (and also its link and description) from a service that encapsulates the required batch query logic.
Change 117424 had a related patch set uploaded by Thiemo Mättig (WMDE):
[WIP] Properly red-link deleted properties and items
Change 125874 had a related patch set uploaded by Thiemo Mättig (WMDE):
Render links to deleted items in red