Page MenuHomePhabricator

Adjust RSS whitelist for mediawiki.org (mediawikiwiki)
Closed, ResolvedPublic

Description

[[mw:Extension:RSS]] has a configurable whitelist. It currently includes https://blog.wikimedia.org/feed/ for mediawikiwiki, but this directive doesn't allow feeds such as https://blog.wikimedia.org/c/technology/mediawiki/feed/ to be included.

Current configuration from https://noc.wikimedia.org/conf/InitialiseSettings.php.txt:


'mediawikiwiki' => array(
'http://blog.wikimedia.org/feed/',
'https://git.wikimedia.org/feed/mediawiki/extensions/Translate.git',
'https://mingle.corp.wikimedia.org/projects/analytics/feeds/8z8k6vUfniLmWc2qGe6GMQsxBujvKRKuybLd8mdTbMFHwGfLH3oxK*MU0E8zM6go.atom',

),

We should either add https://blog.wikimedia.org/c/technology/mediawiki/feed/ explicitly or whitelist all of https://blog.wikimedia.org/ (preferable).


Version: wmf-deployment
Severity: enhancement

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:53 AM
bzimport set Reference to bz61888.
bzimport added a subscriber: Unknown Object (MLST).

As this is marked as "easy" in combination with "shell" (which is not recommended according to the keyword description):
Where would a patch contributor find the file to edit in Git?

(In reply to Andre Klapper from comment #1)

As this is marked as "easy" in combination with "shell" (which is not
recommended according to the keyword description):
Where would a patch contributor find the file to edit in Git?

Its in the operations/mediawiki-config repo.

The no easy+shell thing should perhaps be reconsidered now that those files are in git and anyone can submit a patch. Historically it required someone with actual shell access.

Change 118956 had a related patch set uploaded by 01tonythomas:
Adjust RSS whitelist to allow mediawiki blog feeds

https://gerrit.wikimedia.org/r/118956

explicitly or whitelist all of https://blog.wikimedia.org/ (preferable).

It appears that requires code changes to RSS extension...

tomasz set Security to None.

Change 118956 had a related patch set uploaded (by Dzahn):
Adjust RSS whitelist to allow mediawiki blog feeds

https://gerrit.wikimedia.org/r/118956

I'm not even sure what is that feed bringing exactly, but... Too narrow? At least for the homepage. We agreed on the criteria to use the "technology"tag in the Wikimedia Blog. That should be enough.

Hi all, I just want to say, that I am still with you and the WP project. If urgent patches are needed (what appears not to be the case), I'll be around...

Change 118956 merged by jenkins-bot:
Adjust mediawiki.org RSS whitelist to allow Wikimedia's technology blog feeds

https://gerrit.wikimedia.org/r/118956

Krenair claimed this task.

Both are whitelisted now.