Page MenuHomePhabricator

Crasher in serializer with templated image parameters
Closed, ResolvedPublic

Description

Example issue:
http://parsoid.wmflabs.org:8001/result/ea33a1daa87e0fa9a4e97a2997c5e9683a6c3cb8/plwiki/Pa%C5%84stwa_%C5%9Bwiata

When serializing a link, the serializer encounters an error:
TypeError: Cannot read property 'href' of undefined

at TagTk.genericTokenMethods.getAttributeShadowInfo (/home/gabriel/src/parsoid/lib/mediawiki.parser.defines.js:170:24)

This seems to be caused by a missing ta entry.

A bisection suggests that commit 83b0de03 is to blame.


Version: unspecified
Severity: normal

Details

Reference
bz61928

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:55 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz61928.

Change 115551 had a related patch set uploaded by Subramanya Sastry:
(Bug 61928) Fix WTS to recognize templated attrs in inline images.

https://gerrit.wikimedia.org/r/115551

Change 115551 merged by jenkins-bot:
(Bug 61928) Fix WTS to recognize templated attrs in inline images.

https://gerrit.wikimedia.org/r/115551