Page MenuHomePhabricator

Improve automatic scrolling on preview (can push buttons out of sight)
Closed, InvalidPublic

Description

When pressing the preview button there seems to be some sort of automatic detection that decides whether to
a) jump to the first line of the posts preview to bring it in sight or
b) don't jump when the preview is already in sight to prevent

the page "jumping around" for small posts with only little text.

However this detection does not seem to take the input field and the buttons into account.

Therefore it can happen that by pressing preview the buttons at the bottom and parts of the input field are "pushed out" of the currently visible browser viewport as soon as the preview is displayed, even if all UI elemnts would fit into the height of the browser window.

While this normally only happens on first preview on boards this behaviour is even more annoying when visiting a specific topic via a permalink and replying to the topic (therefore replying at the very end of the page.

In this situation it can even happen that every time one previews the post the buttons are pushed out of view again:

  • When pressing preview the old preview is deleted first.
  • This results in the page becoming "shorter"
  • The browser might therefore scroll up (since it can't scroll past the end of the page)
  • Afterwards the new preview is generated.
  • The browser does not scroll again but everything after the preview is pushed down.
  • As a result even when not changing any text (therefore creating the exact same preview) one is able to scroll the browser up just by pressing preview.

All the above was tested with Windows 7 using Firefox 27.0.1


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61937

Details

Reference
bz61938

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:56 AM
bzimport set Reference to bz61938.
bzimport added a subscriber: Unknown Object (MLST).
Trizek-WMF subscribed.

I don't think that's the case anymore, while the editor has been changed. Please reopen if I'm wrong.