Page MenuHomePhabricator

Audio thumbnails no longer resize
Closed, ResolvedPublic

Description

Author: hahnchen.wikipedia

Description:
[[File:audio.ogg|thumb|left|upright=1.2|foo]]

In May 2013, audio thumbnails such as the example above responded to the "upright" parameter which would alter the width of the thumbnail. In July 2013, this is no longer the case.

In June 2013, it looks like a hack was put in place to ignore all size parameters for audio thumbnails.

https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FTimedMediaHandler/0d23f78b61f441b0eed85d5758eaea463c504abb


Version: unspecified
Severity: normal

Details

Reference
bz61981

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:59 AM
bzimport set Reference to bz61981.

Hmm. What do you expect the upright parameter to actually do? (upright is a bad idea as a feature, I wish it didn't exist).


Audio files support using the width parameter: [[File:Foo.ogg|120px]], provided the width is between 35px and 220px.

I'm unclear if there is still a bug here.

hahnchen.wikipedia wrote:

I expect the upright parameter affect the width of audio thumbnails, just like the width parameter does, reverting to its 2013 behaviour.

It is recommended that the upright parameter be used to resize images. I have placed an audio thumbnail directly above a upright-resized image thumbnail. Both thumbnails used to be the same width, now they are not.

Gilles subscribed.
TheDJ claimed this task.
TheDJ subscribed.

audio fragments have no height, but their width does listen to upright.