Page MenuHomePhabricator

Vertical buttons instead of horizontal
Closed, ResolvedPublic

Description

screenshot of button placement.

On Swedish Wikipedia, the button for finding an article to fix is placed underneath the guide button, instead of to the right, causing the window to get a scroll bar. Either the window should be made bigger to avoid scrolling or the button should be placed to the right.

(Tested in Chrome and Firefox on Ubuntu.)


Version: unspecified
Severity: normal

Attached:

Skärmbild_från_2014-02-27_11:17:06.png (402×665 px, 24 KB)

Details

Reference
bz61992

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:00 AM
bzimport set Reference to bz61992.
bzimport added a subscriber: Unknown Object (MLST).

Just tested the above in different skins:

  • Vector: I get the above result
  • Monobok: I get the correct result (see attachment)
  • Modern: I get nothing
  • Cologne: I get nothing

(All in Firefox)

Created attachment 14701
In Monobook

Attached:

Bugg_from_2014-02-27_14:05:33.png (884×1 px, 207 KB)

Testing uselang=qqx [1] it looks like the source of the problem might be in the text on the edit button doesn't wrap (unlike that of the fix button). As a result if the text is to long the button becomes wider than the default, something which the overlay box does not take into account when determining its width. Which is why you get the error in Swedish but not English.

[1] https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&uselang=qqx

A fix for the problem is changing #mw-gettingstarted-editable-main-edit-page from "min-width: 210px" to "width: 210px". (Although not the best solution imho)

The window is already fixed so there will be no vertical scrollbar. This will roll out to all Wikipedias March 6.

As for putting the buttons on the same line in all languages, that is bug 61922, so I'll mark this a duplicate.

  • This bug has been marked as a duplicate of bug 61922 ***

(In reply to Lokal_Profil from comment #1)

Just tested the above in different skins:

  • Vector: I get the above result
  • Monobok: I get the correct result (see attachment)
  • Modern: I get nothing
  • Cologne: I get nothing

What do you mean, "I get nothing". I see:

Modern (https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons side by side.

ColoneBlue (https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) - Buttons vertically

Where the buttons are might vary, but it should work.

(In reply to Matthew Flaschen from comment #6)

(In reply to Lokal_Profil from comment #1)

Just tested the above in different skins:

  • Vector: I get the above result
  • Monobok: I get the correct result (see attachment)
  • Modern: I get nothing
  • Cologne: I get nothing

What do you mean, "I get nothing". I see:

Modern
(https://sv.wikipedia.org/wiki/
Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
side by side.

ColoneBlue
(https://sv.wikipedia.org/wiki/
Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
Buttons vertically

Where the buttons are might vary, but it should work.

Looked closer at this (CologneBlue and Modern) and not sure what is going on.
Firefox (27.0.1):

  • I don't see any buttons for when logged in to my normal account(s)
  • Buttons appear when logged out.
  • Buttons appear when logged in to a fresh account

Chrome:

  • Buttons appear independently of whether I'm logged in.

Seems like it is a clash between the code for moving categories to the top of the page in my common.js (same as that in the Commons gadget https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js) which doesn't affect those skins anyhow.

swalling wrote:

(In reply to Matthew Flaschen from comment #6)

(In reply to Lokal_Profil from comment #1)

Just tested the above in different skins:

  • Vector: I get the above result
  • Monobok: I get the correct result (see attachment)
  • Modern: I get nothing
  • Cologne: I get nothing

What do you mean, "I get nothing". I see:

Modern
(https://sv.wikipedia.org/wiki/
Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
side by side.

ColoneBlue
(https://sv.wikipedia.org/wiki/
Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
Buttons vertically

Where the buttons are might vary, but it should work.

Yeah I think this is acceptable for now.

Keep in mind that an overwhelming majority of editors who will be seeing this interface will see it with Vector. This is because it shows you the modals right after you register, and thus in order to switch skins they would need to be dismissed or you would have to open Preferences in a new tab then refresh the page.

(In reply to Lokal_Profil from comment #7)

Seems like it is a clash between the code for moving categories to the top
of the page in my common.js (same as that in the Commons gadget
https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
which doesn't affect those skins anyhow.

The reason it doesn't affect those skins is that bodyContent doesn't exist there. However, the script throws an error rather than correctly handling the absence. See https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js

(In reply to Matthew Flaschen from comment #9)

(In reply to Lokal_Profil from comment #7)

Seems like it is a clash between the code for moving categories to the top
of the page in my common.js (same as that in the Commons gadget
https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
which doesn't affect those skins anyhow.

The reason it doesn't affect those skins is that bodyContent doesn't exist
there. However, the script throws an error rather than correctly handling
the absence. See
https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js

Thanks. So unrelated issue which prevented gettingStarted from showing. Updated the commons gadget, unsure if the same also exists on other projects.