Page MenuHomePhabricator

browser readyState should be "loading" until login completes
Closed, InvalidPublic

Description

Seen in fairly recent times, particularly for Internet Explorer:

Seen particularly in browser tests, which move quickly from logging in to a particular URL:

It seems that the browser readyState is moved from "loading" to either "interactive" or "complete" before the login process finishes. I believe this because I see automated tests that log in, then navigate to a URL to perform some action only to get an error message that the user is not logged in.

I got around this by adding some code to the shared login method here to check for complete login before the tests proceed: https://github.com/wikimedia/mediawiki-selenium/commit/a1d7fda4af531773a748f990e294fa5adf0b0628

However, this causes problems for tests for the Language teams because every aspect of the user-specific signs of being logged in (Logout link, Preferences, etc.) is localized, making it difficult or impossible to identify a generic way to confirm login.

It would be better to control the browser readyState properly.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62244

Details

Reference
bz62001

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:00 AM
bzimport set Reference to bz62001.
bzimport added a subscriber: Unknown Object (MLST).
zeljkofilipin claimed this task.
zeljkofilipin subscribed.

I do not remember seeing problems with logging in for a long time. Please reopen if needed.