Page MenuHomePhabricator

Using the language link tool in the sidebar when inside VisualEditor loses the edit without warning
Closed, ResolvedPublic

Description

A user at en.wp reported today that you can add interlanguage links while you're in VE. The last step when doing so means the whole page gets reloaded, so whatever was done in VE until that moment gets lost. I am not aware of ways to prevent this, and there is no indication in VE that this will happen when you start that procedure.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0
See Also:
T54105: [Story] VisualEditor: Ability to edit language links on Wikidata from within the editor

Details

Reference
bz62005

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:00 AM
bzimport set Reference to bz62005.
bzimport added a subscriber: Unknown Object (MLST).

(Filed initially as WD, thought you hadn't mentioned this detail, re-filed again as VE. Close enough.)

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
matmarex moved this task from Freezer to External and Administrivia on the VisualEditor board.
matmarex subscribed.

I think this is no longer a problem.

In the most common case, where the Wikidata item already exists, "Edit links" is just a link to wikidata.org, and it displays a browser warning if clicked while VisualEditor is open (like any other link).

image.png (1×1 px, 402 KB)

When the Wikidata item doesn't exist, it's trickier, since the "Add links" button open a dialog that lets you connect the pages. But this also works mostly fine: after completing the dialog, you still get the browser warning, and will not lose your changes made in VisualEditor unless you confirm that you want to reload the page.

(I found a page I could test this on via Special:UnconnectedPages.)

shot0001.png (1×1 px, 693 KB)

Video recording:

The experience could be better (e.g. Wikibase's page connect dialog could update the page rather than reloading it), but I think it is fine as it is, especially since this feels like a corner case.