Page MenuHomePhabricator
Create Task
Maniphest T64008

Add commonsMedia datatype to harvest_template.py
Closed, ResolvedPublic
Actions

Description

As pointed out in https://www.wikidata.org/wiki/User:Underlying_lk/sandbox#commonsMedia_support_in_harvest_template , it should be relatively easy to add image support.

elif claim.getType() == 'commonsMedia':

mediasite = pywikibot.Site("commons", "commons")
image = pywikibot.ImagePage(mediasite, value)
claim.setTarget(image)

Instead of using ImagePage I think Link() should be used.

Version: core-(2.0)
Severity: normal

Details

Reference
bz62008

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:01 AM
• bzimport added a project: Pywikibot-Wikidata.
• bzimport set Reference to bz62008.
Multichill created this task.Feb 27 2014, 5:54 PM
gerritbot added a comment.Apr 20 2014, 3:46 PM

Change 127478 had a related patch set uploaded by Multichill:
(bug 62008) Added support for images

https://gerrit.wikimedia.org/r/127478

gerritbot added a comment.Apr 20 2014, 4:12 PM

Change 127478 merged by jenkins-bot:
(bug 62008) Added support for images Now with checking for redirect and if the image actually exists

https://gerrit.wikimedia.org/r/127478

Multichill added a comment.Apr 20 2014, 4:14 PM

Implemented. Added a bit more checking:

  • Uses Link instead of Page directly
  • Checks if the imagepage is a redirect
  • Checks if the image actually exists
Aklapper added a project: Pywikibot.Nov 27 2014, 4:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL