Page MenuHomePhabricator

scap-rebuild-cdbs fails with cryptic error messages when scap called with invalid `--versions` command line flag
Closed, InvalidPublic

Description

Running a full scap for just wmf16 branch (scap --versions php-1.23wmf16 'rebuild php-1.23wmf16 l10n cache') failed with:

Warning: opendir(/upstream): failed to open dir: No such file or directory in /srv/scap/bin/mergeCdbFileUpdates on line 76
Could not open directory '/upstream'.

This looks to be a bug in the scap-rebuild-cdbs call when --versions are specified in the scap call.


Version: wmf-deployment
Severity: normal

Details

Reference
bz62018

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM
bzimport added a project: Deployments.
bzimport set Reference to bz62018.

Change 116017 had a related patch set uploaded by BryanDavis:
Validate --versions arguments to scap

https://gerrit.wikimedia.org/r/116017

It turns out that the bug was mostly in my head. Specifically the --versions list is meant to be values such as 1.23wmf16 rather than directory names such as php-1.23wmf16. The input validation and error messages could have been more useful however and it would be nice to fail fast on an error like this rather than failing very noisily after the sync.

Change 116017 abandoned by Ori.livneh:
Validate --versions arguments to scap

Reason:
Suit yourself.

https://gerrit.wikimedia.org/r/116017

Change 116017 restored by BryanDavis:
Validate --versions arguments to scap

Reason:
I'm assuming Ori abandoned my changeset accidentally.

https://gerrit.wikimedia.org/r/116017

Change 116017 abandoned by BryanDavis:
Validate --versions arguments to scap

Reason:
Obsoleted by I956385c

https://gerrit.wikimedia.org/r/116017