Page MenuHomePhabricator

Invalid transclusion of Special:LanguageStats needs to degrade gracefully
Closed, ResolvedPublic

Description

After a certain user added {{Special:LanguageStats/id|suppressempty=0|suppresscomplete=1}} to his userpage, it became just a MediaWiki error message. This should obviously not happen.


Version: unspecified
Severity: major
URL: https://www.mediawiki.org/wiki/Help:Extension:Translate/Statistics_and_reporting

Details

Reference
bz62125

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
bzimport set Reference to bz62125.
bzimport added a subscriber: Unknown Object (MLST).

Context: before https://meta.wikimedia.org/w/index.php?title=User:Aldnonymous&diff=7695825&oldid=7685114 , the invalid syntax resulted in "Exception inside of exception handler" fatal.

Exception from line 6299 of /usr/local/apache/common-local/php-1.24wmf9/includes/parser/Parser.php: Parser state cleared while parsing. Did you call Parser::parse recursively?
#0 /usr/local/apache/common-local/php-1.24wmf9/includes/parser/Parser.php(374): Parser->lock()
#1 /usr/local/apache/common-local/php-1.24wmf9/includes/OutputPage.php(1614): Parser->parse('<div class='err...', Object(Title), Object(ParserOptions), true, true, NULL)
#2 /usr/local/apache/common-local/php-1.24wmf9/includes/OutputPage.php(1554): OutputPage->addWikiTextTitle('<div class='err...', Object(Title), true, false, true)
#3 /usr/local/apache/common-local/php-1.24wmf9/includes/OutputPage.php(3780): OutputPage->addWikiText('<div class='err...')
#4 /usr/local/apache/common-local/php-1.24wmf9/extensions/Translate/specials/SpecialLanguageStats.php(165): OutputPage->wrapWikiMsg('<div class='err...', 'translate-mgs-n...')
#5 /usr/local/apache/common-local/php-1.24wmf9/includes/specialpage/SpecialPage.php(380): SpecialLanguageStats->execute(NULL)
#6 /usr/local/apache/common-local/php-1.24wmf9/includes/specialpage/SpecialPageFactory.php(510): SpecialPage->run(NULL)
#7 /usr/local/apache/common-local/php-1.24wmf9/includes/specialpage/SpecialPageFactory.php(549): SpecialPageFactory::executePath(Object(Title), Object(RequestContext), true)
#8 /usr/local/apache/common-local/php-1.24wmf9/includes/parser/Parser.php(3507): SpecialPageFactory::capturePath(Object(Title), Object(RequestContext))

#9 /usr/local/apache/common-local/php-1.24wmf9/includes/parser/Preprocessor_DOM.php(1175): Parser->braceSubstitution(Array, Object(PPFrame_DOM))

#16 /usr/local/apache/common-local/php-1.24wmf9/includes/poolcounter/PoolCounterWork.php(116): PoolWorkArticleView->doWork()
#17 /usr/local/apache/common-local/php-1.24wmf9/includes/Article.php(665): PoolCounterWork->execute()
#18 /usr/local/apache/common-local/php-1.24wmf9/includes/actions/ViewAction.php(44): Article->view()
#19 /usr/local/apache/common-local/php-1.24wmf9/includes/Wiki.php(431): ViewAction->show()
#20 /usr/local/apache/common-local/php-1.24wmf9/includes/Wiki.php(295): MediaWiki->performAction(Object(Article), Object(Title))
#21 /usr/local/apache/common-local/php-1.24wmf9/includes/Wiki.php(603): MediaWiki->performRequest()
#22 /usr/local/apache/common-local/php-1.24wmf9/includes/Wiki.php(452): MediaWiki->main()
#23 /usr/local/apache/common-local/php-1.24wmf9/index.php(46): MediaWiki->run()

gerrit change 141056 would fix this.

Nikerabbit claimed this task.

That patch has been merged.