Page MenuHomePhabricator
Create Task
Maniphest T64135

PHP strict standards error on TimedMediaHandler
Closed, ResolvedPublic
Actions

Description

PHP Strict standards: Declaration of ForeignApiQueryAllPages::titlePartToKey() should be compatible with that of ApiQueryBase::titlePartToKey() in /vagrant/mediawiki/extensions/TimedMediaHandler/handlers/TextHandler/TextHandler.php on line 15

Version: unspecified
Severity: normal

Details

Reference
bz62135
SubjectRepoBranchLines +/-
Fix php strict errormediawiki/extensions/TimedMediaHandlermaster+1 -1
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
• bzimport added a project: TimedMediaHandler.
• bzimport set Reference to bz62135.
• Manybubbles created this task.Mar 3 2014, 1:42 AM
• Gilles triaged this task as Medium priority.Nov 24 2014, 2:50 PM
• Gilles subscribed.
• Gilles added a project: Multimedia.Nov 24 2014, 3:13 PM
gerritbot subscribed.May 12 2015, 5:33 PM

Change 210397 had a related patch set uploaded (by Paladox):
Fix php strict error

https://gerrit.wikimedia.org/r/210397

gerritbot added a project: Patch-For-Review.May 12 2015, 5:33 PM
Krinkle added subscribers: Anomie, Krinkle.May 12 2015, 10:25 PM
@Manybubbles wrote

PHP Strict standards: Declaration of ForeignApiQueryAllPages::titlePartToKey() should be compatible with that of ApiQueryBase::titlePartToKey() in /vagrant/mediawiki/extensions/TimedMediaHandler/handlers/TextHandler/TextHandler.php on line 15

It seems @Anomie can't reproduce this warning and the source code doesn't contain any mismatch in method signature or visibility. Was this perhaps caused by a local change?

Anomie closed this task as Resolved.EditedMay 13 2015, 6:05 PM
Anomie assigned this task to • Gilles.
Anomie set Security to None.
In T64135#1281122, @Krinkle wrote:

It seems @Anomie can't reproduce this warning

I didn't know I tried? (edit: I was asked on IRC and forgot about it)

and the source code doesn't contain any mismatch in method signature or visibility.

It doesn't now. Apparently it was fixed in Gerrit change 137907, about a month after this bug was filed.

gerritbot added a comment.May 13 2015, 6:06 PM

Change 210397 abandoned by Anomie:
Fix php strict error

Reason:
Original bug was fixed a year ago, nothing to do here.

https://gerrit.wikimedia.org/r/210397

Ricordisamoa removed a project: Patch-For-Review.Mar 26 2016, 11:47 AM
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptMar 26 2016, 11:47 AM
Aklapper removed subscribers: Anomie, • Fabrice_Florin, • Manybubbles.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL