Page MenuHomePhabricator
Create Task
Maniphest T64140

InstantCommons - storage dislocation of generated thumbs
Closed, ResolvedPublic
Actions

Description

I am working in an symlinked environment using a single codebase for multiple wikis.

I observe one strange behaviour regarding the storage of the generated thumbs for files embedded via InstantCommons. Some of them ended up in the image directory of the symlinked codebase and not in the image directory of the respective wiki which is not symlinked.

The thumbs of directly uploaded images end up in the expected location, i.e. /images/thumb/ of the respective wiki. The thumbs of newly via InstantCommons embedded files also end up in the expected directory as expected. The dislocated thumbs continue to be used via the unexpected image directory of the code base.

This dislocation of thumbs seems to have happened during the upgrade process from MW 1.20. to 1.21.

Version: unspecified
Severity: normal

Details

Reference
bz62140

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:52 AM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz62140.
• bzimport added a subscriber: Unknown Object (MLST).
Kghbln created this task.Mar 3 2014, 1:18 PM
• Gilles added a project: Multimedia.Nov 24 2014, 3:33 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:36 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:36 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:11 PM
Restricted Application added a project: Commons. · View Herald TranscriptJan 27 2017, 10:11 PM
zhuyifei1999 removed a project: Commons.Feb 8 2017, 12:29 PM
Kghbln added a comment.Feb 8 2017, 3:46 PM

I guess I should revisit this again. Now that I am moving von 1.23 to 1.27.

Tgr added a comment.Feb 8 2017, 8:17 PM

We should probably backport https://gerrit.wikimedia.org/r/#/c/334181/ to 1.27.

Kghbln added a comment.Feb 8 2017, 8:41 PM

@Tgr Does make sense to me for 1.27 since it is an LTS version. Since 1.27.2 seems to take a bit longer this one could still perfectly squeeze in. :)

Tgr added a comment.Feb 8 2017, 9:01 PM

Backported. With that change, InstantCommons should not store thumbnails anymore unless you change the default settings (they were not used anyway since 1.27, storing them was an oversight).

1.20/1.21 is long unsupported and 1.23 is about to be so we can close this IMO.

Kghbln closed this task as Resolved.EditedFeb 8 2017, 9:19 PM
Kghbln assigned this task to Tgr.

Thanks a lot for doing the backport with https://gerrit.wikimedia.org/r/#/c/336675/1. Much appreciated! Indeed, this may now be closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL