Page MenuHomePhabricator
Create Task
Maniphest T64162

Bad Flow diff link
Closed, ResolvedPublic
Actions

Description

The link https://www.mediawiki.org/w/index.php?title=Talk:Flow&workflow=rpx4cdyu8bls80rm&topic_oldRevision=rq5ggnhkuv7vogqg&topic_newRevision=rq5gfdhkeqju0av4&action=compare-revisions that I found on my watchlist leads to the following internal error massage.

"The action specified by the URL is invalid. You might have mistyped the URL, or followed an incorrect link. This might also indicate a bug in the software used by MediaWiki.
Return to MediaWiki.
[9733c713] 2014-03-03 20:09:17: Fatal exception of type Flow\Exception\InvalidActionException"

Version: unspecified
Severity: normal

Details

Reference
bz62162

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:53 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz62162.
• bzimport added a subscriber: Unknown Object (MLST).
Allen4names created this task.Mar 3 2014, 8:16 PM
Maryana added a comment.Mar 5 2014, 7:30 PM

Thanks for the report, Allen. Just a few questions:

  1. Is this your watchlist on English Wikipedia or Mediawiki.org?
  2. Do you have any special watchlist preferences enabled?
  3. Which link are you clicking to get to that URL? (e.g., "diff" or something like that?)
Maryana added a comment.Mar 5 2014, 7:45 PM

Oh, I think I found it :) On mw.org, when you edit a post, you get a (diff) link at the beginning of the watchlist string, and that generates the bad link.

Allen4names added a comment.Mar 6 2014, 6:40 AM

(In reply to Maryana Pinchuk from comment #1)

Thanks for the report, Allen. Just a few questions:

  1. Is this your watchlist on English Wikipedia or Mediawiki.org?
  2. Do you have any special watchlist preferences enabled?
  3. Which link are you clicking to get to that URL? (e.g., "diff" or

something like that?)

The link above should answer (and confirm what you wrote in comment 2) your first question and yes it is in the 'diff' link. As for my watchlist preferences it is 7 days and a maximum of 250 changes with the following advanced options checked.

  • Add pages and files I edit to my watchlist
  • Add pages and files I move to my watchlist
  • Add pages I create and files I upload to my watchlist
  • Watch threads that I create or reply to

I hope this helps.

• bzimport added a comment.Mar 11 2014, 12:45 AM

bsitu wrote:

Not sure why the bot is not pasting the gerrit link: https://gerrit.wikimedia.org/r/#/c/118040/

gerritbot added a comment.Mar 12 2014, 5:25 PM

Change 118040 had a related patch set uploaded by Addshore:
diff link for a post is action=compare-post-revisions

https://gerrit.wikimedia.org/r/118040

gerritbot added a comment.Mar 13 2014, 11:09 PM

Change 118040 merged by jenkins-bot:
diff link for a post is action=compare-post-revisions

https://gerrit.wikimedia.org/r/118040

PiRSquared17 added a comment.Mar 16 2014, 3:43 PM

Just noticed this bug. Thanks for the patch, Addshore.

PiRSquared17 added a comment.Mar 16 2014, 3:44 PM

(In reply to PiRSquared17 from comment #7)

Just noticed this bug. Thanks for the patch, Addshore.

  • Bsitu
gerritbot added a comment.Mar 18 2014, 12:51 AM

Change 119230 had a related patch set uploaded by Bsitu:
More fix to diff link from contribution & recentchange page

https://gerrit.wikimedia.org/r/119230

• bzimport added a comment.Mar 18 2014, 12:55 AM

bsitu wrote:

Previous patch didn't take header revision into consideration. This should be addressed in the latest patch

gerritbot added a comment.Mar 19 2014, 2:21 PM

Change 119230 merged by jenkins-bot:
More fix to diff link from contribution & recentchange page

https://gerrit.wikimedia.org/r/119230

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL