Page MenuHomePhabricator

VisualEditor: [Regression-pre-1.23wmf17] Cannot select input boxes inside dialogs
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Options>Categories
3.Try to add a category to the page

Observed Result:
Cannot place the cursor in the Add a category text box and cannot add a category

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8
Page: http://en.wikipedia.beta.wmflabs.org/wiki/Newpage3rdfeb?veaction=edit


Version: unspecified
Severity: critical

Attached:

Screen_Shot_2014-03-03_at_12.57.47_PM.png (638×1 px, 117 KB)

Details

Reference
bz62163

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:53 AM
bzimport set Reference to bz62163.

This seems to repeat for all input boxes inside Dialogs. It happens also for alternate text in Media Edit dialog and in the MediaSizeWidget in the same dialog.

The values change properly through the automatic changes (by selecting different options) but the textboxes do not get focused and seem to be non responsive.

Roan suggests that it may be caused by Ed's blur of surface on dialog open.

(In reply to James Forrester from comment #2)

Roan suggests that it may be caused by Ed's blur of surface on dialog open.

I was wrong, it was the autofocusing of pages feature in oojs-ui, which didn't properly respect the config setting that disables it (plus had other issues). Fix inbound from Trevor.

Change 116664 had a related patch set uploaded by Trevor Parscal:
Allow focusing of inputs in booklet layouts without continuous pages

https://gerrit.wikimedia.org/r/116664

Change 116664 merged by jenkins-bot:
Allow focusing of inputs in booklet layouts without continuous pages

https://gerrit.wikimedia.org/r/116664

Fixed in OOjs UI; will be pulled into master for MW-core later today.