Page MenuHomePhabricator

Flow: ?action=edit on a Flow-enabled page or Topic namespace throws exception
Closed, DeclinedPublic

Description

If you follow a redlink to a Flow board, you get an error page

Internal error - {{SITENAME}}
The action specified by the URL is invalid. You might have mistyped the URL, or followed an incorrect link. This might also indicate a bug in the software used by SPageWiki.

and depending on how your wiki is configured for errors, you get:

[0264606c] /wiki/index.php?title=User_talk:Selenium_user&action=edit&redlink=1 Exception from line 80 of /home/spage/projects/core/extensions/Flow/includes/View.php: Unrecognized get action: edit

Currently this is unlikely to happen in production, since we set up Flow in advance on a page-by-page basis. But when we allow Flow user pages, either by $wgFlowOccupyNamespaces or by a beta opt-in features, it's likely to happen.

We could make redlink handling aware of Flow so it just takes you to the Flow board instead of putting action=edit on the URL. But I think it's better and easier for Flow to swallow the exception for action=edit and let the user view the board, since that's the precursor to choosing something to edit (the board header, a topic title, or some post).

Maybe there are other MediaWiki-generated action links that should not result in action errors when performed on Flow boards. We document action handling at https://www.mediawiki.org/wiki/Flow/Architecture#URL_actions

I filed bug 62165 about the garbled {{SITENAME}} in the title, it should be 'nosuchaction'.


Version: master
Severity: major
URL: https://www.mediawiki.org/wiki/Talk:Flow?action=edit
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60936
https://bugzilla.wikimedia.org/show_bug.cgi?id=69879

Details

Reference
bz62173

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:54 AM
bzimport set Reference to bz62173.
bzimport added a subscriber: Unknown Object (MLST).

Not high priority now since we're not rolling Flow out to new pages yet, thus not possible to get to Flow board via redlink.

Note that it's not just redlinks, it's just ?action=edit that causes it.

It's now throwing MWException's.

I can't see any exceptions in this workflow. action=edit redirects to the Flow board.