Page MenuHomePhabricator
Create Task
Maniphest T64174

Use MutationObserver to detect when an OO.ui.Element is attached to a document
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

I3fd1e46459215773b0df137a603d788a81bbd8fb adds code which binds to a DOMNodeInsertedIntoDocument event. That event is deprecated, and will stop working at some point. Supposedly MutationObserver is being added as a part of DOM4 as a replacement. So far, it doesn't appear the DOMNodeInsertedIntoDocument was considered in the design of MutationObserver, but hopefully we can come up with a working solution we can integrate into OO.ui.Element for general use.

Version: unspecified
Severity: enhancement

Details

Reference
bz62174
SubjectRepoBranchLines +/-
TextInputWidget: Use MutationObserver for #onElementAttach supportoojs/uimaster+72 -1
TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocumentoojs/uimaster+23 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:54 AM
• bzimport added a project: OOjs-UI-Technical-Debt.
• bzimport set Reference to bz62174.
• TrevorParscal created this task.Mar 4 2014, 1:13 AM
• TrevorParscal edited projects, added OOUI; removed OOjs-UI-Technical-Debt.Nov 24 2014, 10:15 PM
• Prtksxna subscribed.Dec 1 2014, 4:46 PM
gerritbot added a project: Patch-For-Review.Dec 1 2014, 4:46 PM

Change 176681 had a related patch set uploaded (by Prtksxna):
[WIP] Use MutationObserver instead of DOMNodeInsertedIntoDocument

https://gerrit.wikimedia.org/r/176681

Patch-For-Review

Jdforrester-WMF assigned this task to • Prtksxna.Dec 1 2014, 5:53 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF renamed this task from OOjs UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document to Use MutationObserver to detect when an OO.ui.Element is attached to a document.Dec 2 2014, 12:36 AM
• Prtksxna added a comment.Dec 2 2014, 10:21 AM

This only applies to OO.ui.TextInputWidget, right? I couldn't find any other instances of DOMNodeInsertedIntoDocument.

matmarex subscribed.Feb 1 2015, 1:52 PM

DOMNodeInsertedIntoDocument is not supported in Firefox, by the way.

http://help.dottoro.com/ljfvvdnm.php#additionalEvents
http://jsfiddle.net/xzwj8d7L/

matmarex mentioned this in T64084: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox.Feb 1 2015, 1:53 PM
matmarex added a parent task: T64084: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox.
• Prtksxna added a comment.Feb 7 2015, 12:25 AM

@TrevorParscal you had some thoughts you wanted to share on this. Looking at the review on the patch it seems that using MutationObserver isn't an option at all.

Esanders subscribed.Feb 7 2015, 12:29 AM

Our thoughts were to provide a central API through OO.ui.Element by which it emitted attach and detach events. In the case of MutationObserver that would've used one observer and list of OO.ui.Elements it was observing. However given that IE9/10 support neither MutationObserver or the DOMNodeInsertedIntoDocument mutation event it doesn't look like there's any reasonable way to detect attach/detach events.

gerritbot subscribed.Feb 7 2015, 12:58 AM

Change 176681 abandoned by Prtksxna:
TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument

https://gerrit.wikimedia.org/r/176681

• Prtksxna removed a project: Patch-For-Review.Feb 7 2015, 1:00 AM

Thanks for the clarification @Esanders! I've abandoned the patch.

• Prtksxna removed • Prtksxna as the assignee of this task.Feb 8 2015, 6:45 AM
matmarex closed this task as Declined.Feb 12 2015, 9:41 PM
matmarex claimed this task.
matmarex mentioned this in T89399: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget.

So, this look pretty declined to me, then. I filed T89399 about replacing the current approach with something that would actually work.

matmarex removed a parent task: T64084: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox.Feb 12 2015, 9:42 PM
matmarex added a parent task: T64084: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox.Mar 3 2015, 7:47 PM
matmarex reopened this task as Open.Mar 3 2015, 9:32 PM

Turns out we can actually do this, but it needs a different approach. https://phabricator.wikimedia.org/T89399#1084383

gerritbot added a comment.Mar 3 2015, 9:40 PM

Change 194197 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Use MutationObserver for #onElementAttach support

https://gerrit.wikimedia.org/r/194197

gerritbot added a project: Patch-For-Review.Mar 3 2015, 9:40 PM
Jdforrester-WMF closed this task as Resolved.Mar 10 2015, 11:12 PM
Jdforrester-WMF added projects: OOjs-UI-next-release, VisualEditor 2014/15 Q3 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.
gerritbot added a comment.Mar 10 2015, 11:16 PM

Change 194197 merged by jenkins-bot:
TextInputWidget: Use MutationObserver for #onElementAttach support

https://gerrit.wikimedia.org/r/194197

Krinkle mentioned this in rGOJU3ddb36034047: TextInputWidget: Use MutationObserver for #onElementAttach support.Mar 10 2015, 11:17 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.1), WMF-deploy-2015-03-18_(1.25wmf22); removed OOjs-UI-next-release.Mar 12 2015, 8:57 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 20 2015, 11:33 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL