Page MenuHomePhabricator
Create Task
Maniphest T64188

Replace old serialization code in lib with datamodel serialization
Closed, ResolvedPublic
Actions

Description

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=8

Details

Reference
bz62188
SubjectRepoBranchLines +/-
Remove Lib Serialization #winning ~=[,,_,,]:3mediawiki/extensions/Wikibasemaster+0 -6 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:55 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz62188.
• bzimport added a subscriber: Unknown Object (MLST).
Tobi_WMDE_SW created this task.Mar 4 2014, 11:24 AM
Tobi_WMDE_SW added a comment.Sep 9 2014, 2:09 PM

blocked by:
https://github.com/wmde/WikibaseDataModelSerialization/milestones/WikibaseLib%20feature%20parity

Lydia_Pintscher added a comment.Sep 30 2014, 12:22 PM

Still needed before switch:

  • filtering by language
JeroenDeDauw added a comment.Nov 16 2014, 9:18 PM

This also blocks https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 since the old code contains a lot of the issues it tracks.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:35 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Jimkont subscribed.Feb 28 2015, 7:42 AM
JeroenDeDauw added a comment.Apr 26 2015, 2:56 AM

The "blocker" Use datamodel serialization in Wikibase\Client\Scribunto\EntityAccessor is more like a subtask than a separate task that blocks this one.

thiemowmde mentioned this in T73170: [Story] Ensure feature parity of serialization based on WikibaseDataModelSerialization with what we do with WikibaseLib.May 13 2015, 5:42 PM
Addshore added a subtask: T104180: Use datamodel serialization in Wikibase\Api\ResultBuilder.Jun 29 2015, 10:39 AM
Bene added a parent task: T104895: [Story] Stop using deprecated methods of Entity.Jul 6 2015, 7:57 PM
Ricordisamoa subscribed.Jul 16 2015, 3:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 3:57 PM
Addshore claimed this task.Jul 28 2015, 11:20 AM
Addshore updated the task description. (Show Details)
Addshore set Security to None.
gerritbot subscribed.Jul 28 2015, 4:38 PM

Change 227472 had a related patch set uploaded (by Addshore):
Remove Lib Serialization #winning ~=[,,_,,]:3

https://gerrit.wikimedia.org/r/227472

gerritbot added a project: Patch-For-Review.Jul 28 2015, 4:38 PM
hoo closed subtask T89234: Use datamodel serialization in Wikibase\Client\Scribunto\EntityAccessor as Resolved.Aug 3 2015, 6:49 PM
gerritbot added a comment.Aug 3 2015, 6:50 PM

Change 227472 merged by jenkins-bot:
Remove Lib Serialization #winning ~=[,,_,,]:3

https://gerrit.wikimedia.org/r/227472

Diffusion mentioned this in rMEXT2d8b1f3b906b: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 3 2015, 6:50 PM
Addshore mentioned this in rEWBAbba422de73eb: Remove Lib Serialization #winning ~=[,,_,,]:3.Aug 3 2015, 6:51 PM
JeroenDeDauw closed this task as Resolved.Aug 5 2015, 5:12 AM
JeroenDeDauw closed subtask T104180: Use datamodel serialization in Wikibase\Api\ResultBuilder as Resolved.
JeroenDeDauw removed a parent task: T75863: [Task] Split wikibase.git.Aug 7 2015, 9:03 AM
Ricordisamoa added a comment.Aug 9 2015, 12:44 AM

Macro over9000: over 6000 lines of code deleted

JeroenDeDauw added a comment.Aug 12 2015, 10:46 AM

The drop at the end is mostly this change:

lib.png (687×1 px, 28 KB)

Lydia_Pintscher closed subtask T73170: [Story] Ensure feature parity of serialization based on WikibaseDataModelSerialization with what we do with WikibaseLib as Resolved.Apr 18 2020, 12:37 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptApr 18 2020, 12:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL