Page MenuHomePhabricator
Create Task
Maniphest T64204

Consider removing segmentCount
Closed, ResolvedPublic
Actions

Description

It looks like we can save some code by removing the segmentCount variable. If the number is needed somewhere, we can probably use Object.keys( x ).length instead.

Version: unspecified
Severity: normal

Details

Reference
bz62204

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:56 AM
• bzimport added a project: ContentTranslation.
• bzimport set Reference to bz62204.
Nikerabbit created this task.Mar 4 2014, 2:03 PM
Amire80 added a comment.Mar 21 2014, 10:21 AM

Niklas, which file is it? Such a variable appears in several files.

Nikerabbit added a comment.Mar 21 2014, 3:55 PM

All the several files.

gerritbot added a comment.Apr 25 2014, 10:09 PM

Change 129836 had a related patch set uploaded by Zilch:
Removes 'segmentCount' variable.

https://gerrit.wikimedia.org/r/129836

gerritbot added a comment.Apr 28 2014, 4:13 AM

Change 129836 merged by jenkins-bot:
Removes 'segmentCount' variable.

https://gerrit.wikimedia.org/r/129836

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL