Page MenuHomePhabricator

Language.php L217: Invalid language code "[[:int:lang] "
Closed, ResolvedPublic

Description

Exception log from fluorine

To reproduce, visit http://commons.wikimedia.org/wiki/User:Pere_prlpz/gallery/14

One of the frames in the call stack is:
Scribunto_LuaSandboxCallback->formatNum('[[:int:lang]]U...', 41)

..which made me suspect Scribunto. But I haven't investigated.

Stack trace attached.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz62242

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
bzimport added a project: Scribunto.
bzimport set Reference to bz62242.
bzimport added a subscriber: Unknown Object (MLST).

My initial reaction would be somebody doing mw.getLanguage( <random parsed wikitext here> ); - not enough error checking to handle the invalid language situation, Language::factory throws a MWException which nobody catches. But haven't looked into it to confirm that.

Change 116984 had a related patch set uploaded by Anomie:
mw.language: Fix exceptions and add tests

https://gerrit.wikimedia.org/r/116984

Change 116984 merged by jenkins-bot:
mw.language: Fix exceptions and add tests

https://gerrit.wikimedia.org/r/116984

This should be deployed to WMF wikis with 1.23wmf18, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.