Page MenuHomePhabricator
Create Task
Maniphest T64268

HTMLForm multiselect broken with integer values
Closed, ResolvedPublic
Actions

Description

When the option values for a multiselect are integers rather than strings, none are checked since Gerrit change 114066. See, for example, the search preference checkboxes on Special:Preferences.

Version: 1.23.0
Severity: normal

Details

Reference
bz62268

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:01 AM
• bzimport added projects: MW-1.23.0-release, MediaWiki-Core-Preferences.
• bzimport set Reference to bz62268.
Anomie created this task.Mar 5 2014, 8:25 PM
gerritbot added a comment.Mar 5 2014, 8:26 PM

Change 117038 had a related patch set uploaded by Anomie:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117038

gerritbot added a comment.Mar 5 2014, 9:02 PM

Change 117038 merged by jenkins-bot:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117038

matmarex added a comment.Mar 5 2014, 10:01 PM

I assume the above patch fixes this. Needs backporting to WMF?

Anomie added a comment.Mar 5 2014, 10:08 PM

Already scheduled for the LD at 23:59 UTC

gerritbot added a comment.Mar 5 2014, 11:43 PM

Change 117113 had a related patch set uploaded by Anomie:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117113

gerritbot added a comment.Mar 5 2014, 11:43 PM

Change 117114 had a related patch set uploaded by Anomie:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117114

gerritbot added a comment.Mar 6 2014, 12:01 AM

Change 117114 merged by jenkins-bot:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117114

gerritbot added a comment.Mar 6 2014, 12:01 AM

Change 117113 merged by jenkins-bot:
HTMLForm: Clean up 0 handling

https://gerrit.wikimedia.org/r/117113

Aklapper removed subscribers: Anomie, • werdna.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL