Page MenuHomePhabricator

MultimediaViewer should display license short name also for CC-BY-SA-XX
Closed, ResolvedPublic

Description

Creative Commons licenses have been ported in various jurisdictions, resulting in many variants CC-by-SA-XX (such as CC-by-SA-ee for Estonia).

MultimediaViewer should display the BY and SA icons for these licenses just like it does for CC-BY-SA

Example:
https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Telleri%20kabel.jpg

(This is also valid for CC-by-ee)


Version: unspecified
Severity: normal

Details

Reference
bz62275

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:01 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz62275.
bzimport added a subscriber: Unknown Object (MLST).

We never display any other icons than the CC logo, but we do display the name of the license as plain text after the logo in some cases, you probably mean that.

CommonsMetadata reports the license (correctly) as cc-by-sa-3.0-ee. The current MultimediaViewer behavior is to look for the multimediaviewer-license-<licensename> message, then fall back to multimediaviewer-license-default; the message is only defined for the main license variants.

We should either cut off the national part before looking for a message, or not use a message at all, and just display the license name as-is. Is there any benefit to using messages here? Does it make sense to translate strings like "CC-BY-SA-3.0"? Maybe to non-latin alphabets?

(In reply to Tisza Gergő from comment #1)

We never display any other icons than the CC logo, but we do display the
name of the license as plain text after the logo in some cases, you probably
mean that.

Yes of course you’re right (seems I have an integrated CC icons adder in my eyes ;-þ)

CommonsMetadata reports the license (correctly) as cc-by-sa-3.0-ee. The
current MultimediaViewer behavior is to look for the
multimediaviewer-license-<licensename> message, then fall back to
multimediaviewer-license-default; the message is only defined for the main
license variants.

Oh, I see − as these messages are marked as optional I never noticed them in TranslateWiki.

Wouldn’t it make more sense to have these messages in Extension:Wikimedia Creative Commons license texts & Extension:Wikimedia license texts though? (if it is possible to leverage on those from MMV afterwards of course?)

We should either cut off the national part before looking for a message, or
not use a message at all, and just display the license name as-is. Is there
any benefit to using messages here? Does it make sense to translate strings
like "CC-BY-SA-3.0"? Maybe to non-latin alphabets?

It appears to make sense, for languages like [ja] or [fa].

[fa] https://creativecommons.org/licenses/by/3.0/deed.fa
[ja] https://creativecommons.org/licenses/by/3.0/deed.ja

(In reply to Jean-Fred from comment #2)

It appears to make sense, for languages like [ja] or [fa].

[fa] https://creativecommons.org/licenses/by/3.0/deed.fa
[ja] https://creativecommons.org/licenses/by/3.0/deed.ja

Those also seem to use "CC-BY 3.0" as the short name, though.

Wouldn’t it make more sense to have these messages in Extension:Wikimedia
Creative Commons license texts & Extension:Wikimedia license texts though?
(if it is possible to leverage on those from MMV afterwards of course?)

I couldn't find those, did you mean Extension:WikimediaMessages? That is a (fairly ugly) hack to override generic translations with WMF-specific ones; it only makes sense when there is a generic message defined by some other extension.
(But it would be nice to have these texts at a more central location instead of MultimediaViewer, yeah.)

(In reply to Tisza Gergő from comment #3)

(In reply to Jean-Fred from comment #2)

It appears to make sense, for languages like [ja] or [fa].

[fa] https://creativecommons.org/licenses/by/3.0/deed.fa
[ja] https://creativecommons.org/licenses/by/3.0/deed.ja

Those also seem to use "CC-BY 3.0" as the short name, though.

Yeah. Short name (as defined in the license templates metadata) might be good enough in many cases ; I wonder about other licenses − the FAL comes to mind, but more generally the truckloads we have on Commons that may (or may not) need a localisation for their short name. But on top of my head, I think shortname would be good enough in most cases.

Wouldn’t it make more sense to have these messages in Extension:Wikimedia
Creative Commons license texts & Extension:Wikimedia license texts though?
(if it is possible to leverage on those from MMV afterwards of course?)

I couldn't find those, did you mean Extension:WikimediaMessages? That is a
(fairly ugly) hack to override generic translations with WMF-specific ones;
it only makes sense when there is a generic message defined by some other
extension.
(But it would be nice to have these texts at a more central location instead
of MultimediaViewer, yeah.)

Ah, I was using the names displayed in TranslateWiki without checking. Yes I meant [[Extension:WikimediaMessages]] & [[Extension:WikimediaLicenseTexts]] (which seem to be more or less part of the same thing?)

We display the shortname now if we don't have a matching message.